You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Juhani Connolly <ju...@gmail.com> on 2012/07/11 10:57:47 UTC
Review Request: FLUME-1363: add trying mutiple ports to the NetcatSource
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5906/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Added port failover as with other channels. I also made the source throw a FlumeException on failure to start. Perhaps this is too harsh, and I can remove it/test if the source has correctly started instead.
Also moved super.start/stop() to the end of their respective functions, as the lifecycle state shouldn't be updated until the source is actually started/stopped
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java 9d28cda
flume-ng-node/src/test/java/org/apache/flume/source/TestNetcatSource.java c195db7
Diff: https://reviews.apache.org/r/5906/diff/
Testing
-------
Updated test confirmed working
Thanks,
Juhani Connolly
Re: Review Request: FLUME-1363: add trying mutiple ports to the NetcatSource
Posted by Hari Shreedharan <hs...@cloudera.com>.
> On July 11, 2012, 9:19 p.m., Hari Shreedharan wrote:
> > Ship It!
Please attach the patch to the jira. Thanks.
- Hari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5906/#review9096
-----------------------------------------------------------
On July 11, 2012, 8:57 a.m., Juhani Connolly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5906/
> -----------------------------------------------------------
>
> (Updated July 11, 2012, 8:57 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Added port failover as with other channels. I also made the source throw a FlumeException on failure to start. Perhaps this is too harsh, and I can remove it/test if the source has correctly started instead.
>
> Also moved super.start/stop() to the end of their respective functions, as the lifecycle state shouldn't be updated until the source is actually started/stopped
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java 9d28cda
> flume-ng-node/src/test/java/org/apache/flume/source/TestNetcatSource.java c195db7
>
> Diff: https://reviews.apache.org/r/5906/diff/
>
>
> Testing
> -------
>
> Updated test confirmed working
>
>
> Thanks,
>
> Juhani Connolly
>
>
Re: Review Request: FLUME-1363: add trying mutiple ports to the NetcatSource
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5906/#review9096
-----------------------------------------------------------
Ship it!
Ship It!
- Hari Shreedharan
On July 11, 2012, 8:57 a.m., Juhani Connolly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5906/
> -----------------------------------------------------------
>
> (Updated July 11, 2012, 8:57 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Added port failover as with other channels. I also made the source throw a FlumeException on failure to start. Perhaps this is too harsh, and I can remove it/test if the source has correctly started instead.
>
> Also moved super.start/stop() to the end of their respective functions, as the lifecycle state shouldn't be updated until the source is actually started/stopped
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java 9d28cda
> flume-ng-node/src/test/java/org/apache/flume/source/TestNetcatSource.java c195db7
>
> Diff: https://reviews.apache.org/r/5906/diff/
>
>
> Testing
> -------
>
> Updated test confirmed working
>
>
> Thanks,
>
> Juhani Connolly
>
>