You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Volodymyr Verovkin (Code Review)" <ge...@cloudera.org> on 2020/04/03 22:21:38 UTC
[kudu-CR] [python] KUDU-2632 Add DATE type support
Volodymyr Verovkin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15645
Change subject: [python] KUDU-2632 Add DATE type support
......................................................................
[python] KUDU-2632 Add DATE type support
There are two utility functions which perfrom conversion between
Kudu DATE and Python datetime.date:
unix_epoch_days_to_date() - converts number of days since Unix
ecpoch to datetime.date()
date_to_unix_epoch_days() - converts datetime.date() to number
of days since Unix ecpoch
Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
M python/kudu/tests/test_schema.py
M python/kudu/tests/util.py
M python/kudu/util.py
9 files changed, 104 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/15645/1
--
To view, visit http://gerrit.cloudera.org:8080/15645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25
Gerrit-Change-Number: 15645
Gerrit-PatchSet: 1
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR] [python] KUDU-2632 Add DATE type support
Posted by "Volodymyr Verovkin (Code Review)" <ge...@cloudera.org>.
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15645 )
Change subject: [python] KUDU-2632 Add DATE type support
......................................................................
Patch Set 3:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/tests/test_scanner.py
File python/kudu/tests/test_scanner.py:
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/tests/test_scanner.py@349
PS1, Line 349: self.assertEqual(types[0], np.int64)
: self.assertEqual(types[1], 'datetime64[ns, UTC]')
: self.assertEqual(types[2], np.object)
: self.assertEqual(types[3], np.object)
: self.assertEqual(types[4], np.bool)
: self.assertEqual(types[5], np.float64)
: self.assertEqual(types[6], np.int8)
: self.assertEqual(types[7], np.object)
: self.assertEqual(types[8], np.object)
: self.assertEqual(types[9], np.object)
: self.assertEqual(types[10], np.float32)
: else:
: self.assertEqual(types[0], np.int64)
: self.assertEqual(types[1], 'datetime64[ns, UTC]')
: self.assertEqual(types[2], np.object)
: self.assertEqual(types[3], np.bool)
: self.assertEqual(types[4], np.float64)
: self.assertEqual(types[5], np.int8)
: self.assertEqual(types[6], np.object)
> It seems this needs to be updated to accommodate for newly added columns of
Done
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py
File python/kudu/util.py:
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@186
PS1, Line 186: Convert
> If following the same style of the docs as for the other functions in this
Done
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@188
PS1, Line 188: of seconds per day (86400).
> nit: add a period
Done
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@189
PS1, Line 189:
> extra spaces
Done
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@190
PS1, Line 190: Parameters
> Could you add information about the parameter of this function into the doc
Done
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@198
PS1, Line 198: """
> Convert
Done
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@199
PS1, Line 199: return datetime.datetime.utcfromtimestamp(ndays * 86400).date()
> nit: add a period
Done
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@203
PS1, Line 203: Convert d
> Is this a mismatch between the actual name of the parameter and the documen
Done
--
To view, visit http://gerrit.cloudera.org:8080/15645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25
Gerrit-Change-Number: 15645
Gerrit-PatchSet: 3
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Apr 2020 16:53:20 +0000
Gerrit-HasComments: Yes
[kudu-CR] [python] KUDU-2632 Add DATE type support
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15645 )
Change subject: [python] KUDU-2632 Add DATE type support
......................................................................
[python] KUDU-2632 Add DATE type support
There are two utility functions which perfrom conversion between
Kudu DATE and Python datetime.date:
unix_epoch_days_to_date() - converts number of days since Unix
ecpoch to datetime.date()
date_to_unix_epoch_days() - converts datetime.date() to number
of days since Unix ecpoch
Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25
Reviewed-on: http://gerrit.cloudera.org:8080/15645
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
M python/kudu/tests/test_schema.py
M python/kudu/tests/util.py
M python/kudu/util.py
9 files changed, 113 insertions(+), 11 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25
Gerrit-Change-Number: 15645
Gerrit-PatchSet: 6
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR] [python] KUDU-2632 Add DATE type support
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15645 )
Change subject: [python] KUDU-2632 Add DATE type support
......................................................................
Patch Set 3:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/15645/3/python/kudu/tests/test_scanner.py
File python/kudu/tests/test_scanner.py:
http://gerrit.cloudera.org:8080/#/c/15645/3/python/kudu/tests/test_scanner.py@a365
PS3, Line 365:
What happened to types[8] here? Should the change to be to add types[9]?
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/tests/util.py
File python/kudu/tests/util.py:
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/tests/util.py@112
PS1, Line 112: datetime.date(2020,1,1)
> I think for this kind of testing we just need to write tests for util funct
This could be done in a follow up patch.
http://gerrit.cloudera.org:8080/#/c/15645/3/python/kudu/util.py
File python/kudu/util.py:
http://gerrit.cloudera.org:8080/#/c/15645/3/python/kudu/util.py@201
PS3, Line 201: dat
nit: date
http://gerrit.cloudera.org:8080/#/c/15645/3/python/kudu/util.py@208
PS3, Line 208: dat
here too
--
To view, visit http://gerrit.cloudera.org:8080/15645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25
Gerrit-Change-Number: 15645
Gerrit-PatchSet: 3
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Apr 2020 23:24:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] [python] KUDU-2632 Add DATE type support
Posted by "Volodymyr Verovkin (Code Review)" <ge...@cloudera.org>.
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15645 )
Change subject: [python] KUDU-2632 Add DATE type support
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/15645/3/python/kudu/tests/test_scanner.py
File python/kudu/tests/test_scanner.py:
http://gerrit.cloudera.org:8080/#/c/15645/3/python/kudu/tests/test_scanner.py@a365
PS3, Line 365:
> What happened to types[8] here? Should the change to be to add types[9]?
Done
http://gerrit.cloudera.org:8080/#/c/15645/3/python/kudu/util.py
File python/kudu/util.py:
http://gerrit.cloudera.org:8080/#/c/15645/3/python/kudu/util.py@201
PS3, Line 201: dat
> nit: date
Done
http://gerrit.cloudera.org:8080/#/c/15645/3/python/kudu/util.py@208
PS3, Line 208: dat
> here too
Done
--
To view, visit http://gerrit.cloudera.org:8080/15645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25
Gerrit-Change-Number: 15645
Gerrit-PatchSet: 4
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Apr 2020 01:00:32 +0000
Gerrit-HasComments: Yes
[kudu-CR] [python] KUDU-2632 Add DATE type support
Posted by "Volodymyr Verovkin (Code Review)" <ge...@cloudera.org>.
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15645 )
Change subject: [python] KUDU-2632 Add DATE type support
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15645/3/python/kudu/util.py
File python/kudu/util.py:
http://gerrit.cloudera.org:8080/#/c/15645/3/python/kudu/util.py@197
PS3, Line 197: nday
> nit: ndays
Done
--
To view, visit http://gerrit.cloudera.org:8080/15645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25
Gerrit-Change-Number: 15645
Gerrit-PatchSet: 5
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Apr 2020 01:01:54 +0000
Gerrit-HasComments: Yes
[kudu-CR] [python] KUDU-2632 Add DATE type support
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15645 )
Change subject: [python] KUDU-2632 Add DATE type support
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/tests/util.py
File python/kudu/tests/util.py:
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/tests/util.py@112
PS1, Line 112: datetime.date(2020,1,1)
> This could be done in a follow up patch.
+1 for doing this in a follow-up patch.
http://gerrit.cloudera.org:8080/#/c/15645/3/python/kudu/util.py
File python/kudu/util.py:
http://gerrit.cloudera.org:8080/#/c/15645/3/python/kudu/util.py@197
PS3, Line 197: nday
nit: ndays
--
To view, visit http://gerrit.cloudera.org:8080/15645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25
Gerrit-Change-Number: 15645
Gerrit-PatchSet: 3
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Apr 2020 00:52:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] [python] KUDU-2632 Add DATE type support
Posted by "Volodymyr Verovkin (Code Review)" <ge...@cloudera.org>.
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15645 )
Change subject: [python] KUDU-2632 Add DATE type support
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/tests/util.py
File python/kudu/tests/util.py:
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/tests/util.py@112
PS1, Line 112: datetime.date(2020,1,1)
> For the sake of covering corner cases and making sure datetime.date() prope
I think for this kind of testing we just need to write tests for util functions unix_epoch_days_to_date() and date_to_unix_epoch_days()
--
To view, visit http://gerrit.cloudera.org:8080/15645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25
Gerrit-Change-Number: 15645
Gerrit-PatchSet: 3
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Apr 2020 17:34:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] [python] KUDU-2632 Add DATE type support
Posted by "Volodymyr Verovkin (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15645
to look at the new patch set (#3).
Change subject: [python] KUDU-2632 Add DATE type support
......................................................................
[python] KUDU-2632 Add DATE type support
There are two utility functions which perfrom conversion between
Kudu DATE and Python datetime.date:
unix_epoch_days_to_date() - converts number of days since Unix
ecpoch to datetime.date()
date_to_unix_epoch_days() - converts datetime.date() to number
of days since Unix ecpoch
Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
M python/kudu/tests/test_schema.py
M python/kudu/tests/util.py
M python/kudu/util.py
9 files changed, 113 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/15645/3
--
To view, visit http://gerrit.cloudera.org:8080/15645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25
Gerrit-Change-Number: 15645
Gerrit-PatchSet: 3
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [python] KUDU-2632 Add DATE type support
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15645 )
Change subject: [python] KUDU-2632 Add DATE type support
......................................................................
Patch Set 1:
(7 comments)
Python test kudu.tests.test_scanner.TestScanner.test_scanner_to_pandas_types is failing:
http://jenkins.kudu.apache.org/job/kudu-gerrit/21294/BUILD_TYPE=DEBUG/testReport/junit/kudu.tests.test_scanner/TestScanner/test_scanner_to_pandas_types/
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py
File python/kudu/util.py:
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@186
PS1, Line 186: Converts
If following the same style of the docs as for the other functions in this file, this should be 'Convert'.
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@188
PS1, Line 188: of seconds per day (86400)
nit: add a period
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@189
PS1, Line 189:
extra spaces
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@190
PS1, Line 190: Returns
Could you add information about the parameter of this function into the doc header using the same style as in other functions?
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@198
PS1, Line 198: Converts
Convert
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@199
PS1, Line 199: the number of days since the unix epoch
nit: add a period
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/util.py@203
PS1, Line 203: timestamp
Is this a mismatch between the actual name of the parameter and the documented name?
--
To view, visit http://gerrit.cloudera.org:8080/15645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25
Gerrit-Change-Number: 15645
Gerrit-PatchSet: 1
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 04 Apr 2020 00:36:53 +0000
Gerrit-HasComments: Yes
[kudu-CR] [python] KUDU-2632 Add DATE type support
Posted by "Volodymyr Verovkin (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15645
to look at the new patch set (#2).
Change subject: [python] KUDU-2632 Add DATE type support
......................................................................
[python] KUDU-2632 Add DATE type support
There are two utility functions which perfrom conversion between
Kudu DATE and Python datetime.date:
unix_epoch_days_to_date() - converts number of days since Unix
ecpoch to datetime.date()
date_to_unix_epoch_days() - converts datetime.date() to number
of days since Unix ecpoch
Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
M python/kudu/tests/test_schema.py
M python/kudu/tests/util.py
M python/kudu/util.py
9 files changed, 108 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/15645/2
--
To view, visit http://gerrit.cloudera.org:8080/15645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25
Gerrit-Change-Number: 15645
Gerrit-PatchSet: 2
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [python] KUDU-2632 Add DATE type support
Posted by "Volodymyr Verovkin (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15645
to look at the new patch set (#4).
Change subject: [python] KUDU-2632 Add DATE type support
......................................................................
[python] KUDU-2632 Add DATE type support
There are two utility functions which perfrom conversion between
Kudu DATE and Python datetime.date:
unix_epoch_days_to_date() - converts number of days since Unix
ecpoch to datetime.date()
date_to_unix_epoch_days() - converts datetime.date() to number
of days since Unix ecpoch
Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
M python/kudu/tests/test_schema.py
M python/kudu/tests/util.py
M python/kudu/util.py
9 files changed, 113 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/15645/4
--
To view, visit http://gerrit.cloudera.org:8080/15645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25
Gerrit-Change-Number: 15645
Gerrit-PatchSet: 4
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR] [python] KUDU-2632 Add DATE type support
Posted by "Volodymyr Verovkin (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15645
to look at the new patch set (#5).
Change subject: [python] KUDU-2632 Add DATE type support
......................................................................
[python] KUDU-2632 Add DATE type support
There are two utility functions which perfrom conversion between
Kudu DATE and Python datetime.date:
unix_epoch_days_to_date() - converts number of days since Unix
ecpoch to datetime.date()
date_to_unix_epoch_days() - converts datetime.date() to number
of days since Unix ecpoch
Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
M python/kudu/tests/test_schema.py
M python/kudu/tests/util.py
M python/kudu/util.py
9 files changed, 113 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/15645/5
--
To view, visit http://gerrit.cloudera.org:8080/15645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25
Gerrit-Change-Number: 15645
Gerrit-PatchSet: 5
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR] [python] KUDU-2632 Add DATE type support
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15645 )
Change subject: [python] KUDU-2632 Add DATE type support
......................................................................
Patch Set 5: Code-Review+2
Looks good to me, but maybe other people have more feedback.
--
To view, visit http://gerrit.cloudera.org:8080/15645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25
Gerrit-Change-Number: 15645
Gerrit-PatchSet: 5
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Apr 2020 04:32:49 +0000
Gerrit-HasComments: No
[kudu-CR] [python] KUDU-2632 Add DATE type support
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15645 )
Change subject: [python] KUDU-2632 Add DATE type support
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25
Gerrit-Change-Number: 15645
Gerrit-PatchSet: 5
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Apr 2020 13:17:44 +0000
Gerrit-HasComments: No
[kudu-CR] [python] KUDU-2632 Add DATE type support
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15645 )
Change subject: [python] KUDU-2632 Add DATE type support
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/tests/test_scanner.py
File python/kudu/tests/test_scanner.py:
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/tests/test_scanner.py@349
PS1, Line 349: self.assertEqual(types[0], np.int64)
: self.assertEqual(types[1], 'datetime64[ns, UTC]')
: self.assertEqual(types[2], np.object)
: self.assertEqual(types[3], np.object)
: self.assertEqual(types[4], np.bool)
: self.assertEqual(types[5], np.float64)
: self.assertEqual(types[6], np.int8)
: self.assertEqual(types[7], np.object)
: self.assertEqual(types[8], np.object)
: self.assertEqual(types[9], np.float32)
: else:
: self.assertEqual(types[0], np.int64)
: self.assertEqual(types[1], 'datetime64[ns, UTC]')
: self.assertEqual(types[2], np.object)
: self.assertEqual(types[3], np.bool)
: self.assertEqual(types[4], np.float64)
: self.assertEqual(types[5], np.int8)
: self.assertEqual(types[6], np.object)
: self.assertEqual(types[7], np.object)
It seems this needs to be updated to accommodate for newly added columns of DATE type.
--
To view, visit http://gerrit.cloudera.org:8080/15645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25
Gerrit-Change-Number: 15645
Gerrit-PatchSet: 1
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 04 Apr 2020 00:54:09 +0000
Gerrit-HasComments: Yes
[kudu-CR] [python] KUDU-2632 Add DATE type support
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15645 )
Change subject: [python] KUDU-2632 Add DATE type support
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/tests/util.py
File python/kudu/tests/util.py:
http://gerrit.cloudera.org:8080/#/c/15645/1/python/kudu/tests/util.py@112
PS1, Line 112: datetime.date(2020,1,1)
For the sake of covering corner cases and making sure datetime.date() properly maps into the underlying types, does it make sense to add a scenario to write a rows with DATE column values of
datetime.date(datetime.MINYEAR, 1, 1)
datetime.date(datetime.MAXYEAR, 12, 31)
?
--
To view, visit http://gerrit.cloudera.org:8080/15645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f08946e9ba56dab5e5b43e2bf65bc535c26ab25
Gerrit-Change-Number: 15645
Gerrit-PatchSet: 1
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 04 Apr 2020 01:21:10 +0000
Gerrit-HasComments: Yes