You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/15 21:16:31 UTC
[GitHub] [arrow-nanoarrow] lidavidm opened a new issue, #21: Demonstrate vendoring + symbol renaming
lidavidm opened a new issue, #21:
URL: https://github.com/apache/arrow-nanoarrow/issues/21
Just to prove our claim of being easily embeddable, and to make sure that things work if multiple versions of nanoarrow end up in a binary (e.g. through two different dependencies)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] paleolimbot commented on issue #21: Demonstrate vendoring + symbol renaming
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on issue #21:
URL: https://github.com/apache/arrow-nanoarrow/issues/21#issuecomment-1216064759
I was thinking that an `examples/` directory should exist...this should definitely be one of them!
With respect to symbol renaming, I've only seen this in H3: https://github.com/uber/h3/blob/master/src/h3lib/include/h3api.h.in#L27-L50 . Should we do that here or is there another thing I should be using? Privately linking to a static library should also work, correct?
One could also use external function declarations as `NANOARROW_DLL void ArrowSomething();`, which might allow something like `#define NANOARROW_DLL static (inline?)` to get a header-only version? I don't want to go too crazy on the `#define` options because I find that kind of thing annoying when other libraries do it, but that one seems like it might allow some flexibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] lidavidm commented on issue #21: Demonstrate vendoring + symbol renaming
Posted by GitBox <gi...@apache.org>.
lidavidm commented on issue #21:
URL: https://github.com/apache/arrow-nanoarrow/issues/21#issuecomment-1216068768
jemalloc lets you do it as well (it's used in Arrow C++), though I'm not sure how it works there. (In that case, symbols are renamed, but still accessible.)
I think this is orthogonal to whether it's header-only, we can also use compiler/linker options (e.g. to give all nanoarrow symbols internal linkage).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] paleolimbot closed issue #21: Demonstrate vendoring + symbol renaming
Posted by GitBox <gi...@apache.org>.
paleolimbot closed issue #21: Demonstrate vendoring + symbol renaming
URL: https://github.com/apache/arrow-nanoarrow/issues/21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org