[jira] [Commented] (FLINK-9969) Unreasonable memory requirements to complete examples/batch/WordCount

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567019#comment-16567019 ] 

ASF GitHub Bot commented on FLINK-9969:
---------------------------------------

tillrohrmann opened a new pull request #6479: [FLINK-9969][batch] Dispose InMemorySorters created by the UnilateralSortMerger
URL: https://github.com/apache/flink/pull/6479
 
 
   ## What is the purpose of the change
   
   This commit changes the behaviour of the UnilateralSortMerger to keep references of the created
   InMemorySorters in order to explicitly dispse them when the sort merger is closed. This prevents
   that InMemorySorters leak and block the garbage collection of MemorySegments to which they keep
   references.
   
   cc @StephanEwen 
   
   ## Brief change log
   
   - Introduce `InMemorySorterFactory` to make `UnilateralSortMerger` testable
   - Keep reference to created `InMemorySorters` in `UnilateralSortMerger`
   - Dispose all `InMemorySorters` before releasing memory to `MemoryManager`
   
   ## Verifying this change
   
   - Added `UnilateralSortMergerTest#testInMemorySorterDisposal`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Unreasonable memory requirements to complete examples/batch/WordCount
> ---------------------------------------------------------------------
>
>                 Key: FLINK-9969
>                 URL: https://issues.apache.org/jira/browse/FLINK-9969
>             Project: Flink
>          Issue Type: Bug
>          Components: ResourceManager
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.6.0
>            Reporter: Piotr Nowojski
>            Assignee: Till Rohrmann
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.5.3, 1.6.0
>
>         Attachments: yarn_logs
>
>
> setup on AWS EMR:
>  * 5 worker nodes (m4.4xlarge nodes) 
>  * 1 master node (m4.large)
> following command fails with out of memory errors:
> {noformat}
> export HADOOP_CLASSPATH=`hadoop classpath`
> ./bin/flink run -m yarn-cluster -p 20 -yn 5 -ys 4 -ytm 16000 examples/batch/WordCount.jar{noformat}
> Only increasing memory over 17.2GB example completes. At the same time after disabling flip6 following command succeeds:
> {noformat}
> export HADOOP_CLASSPATH=`hadoop classpath`
> ./bin/flink run -m yarn-cluster -p 20 -yn 5 -ys 4 -ytm 1000 examples/batch/WordCount.jar{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)