You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2016/10/04 14:42:55 UTC

[GitHub] brooklyn-server issue #366: Test jclouds location choose reachable address

Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/366
  
    Looks great - love the way you have made `JcloudsReachableAddressStubbedTest` a true unit test by stubbing out the `TemplateBuilder` with `JcloudsStubTemplateBuilder`.
    
    I may take a look at that separately, for how much we hardcode in `JcloudsStubTemplateBuilder`. And look at using that in more of our tests that don't actually require real responses from the cloud provider!
    
    Merging now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---