You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Yonik Seeley (JIRA)" <ji...@apache.org> on 2010/02/17 23:23:27 UTC
[jira] Created: (SOLR-1777) fields with sortMissingLast don't sort
correctly
fields with sortMissingLast don't sort correctly
------------------------------------------------
Key: SOLR-1777
URL: https://issues.apache.org/jira/browse/SOLR-1777
Project: Solr
Issue Type: Bug
Components: search
Affects Versions: 1.4
Reporter: Yonik Seeley
Assignee: Yonik Seeley
Priority: Critical
field types with the sortMissingLast=true attribute can have results sorted incorrectly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (SOLR-1777) fields with
sortMissingLast don't sort correctly
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835039#action_12835039 ]
Yonik Seeley edited comment on SOLR-1777 at 2/18/10 12:23 AM:
--------------------------------------------------------------
The issue had to do with ords and ord normalization in sort-missing-last.
Here's a patch with tests and a rewritten MissingLastOrdComparator that manipulates ord values rather than trying to just handle nulls.
note: not all tests pass yet.
was (Author: yseeley@gmail.com):
The issue had to do with ords and ord normalization in sort-missing-last.
Here's a patch with tests and a rewritten MissingLastOrdComparator that manipulates ord values rather than trying to just handle nulls.
> fields with sortMissingLast don't sort correctly
> ------------------------------------------------
>
> Key: SOLR-1777
> URL: https://issues.apache.org/jira/browse/SOLR-1777
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.4
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Priority: Critical
> Attachments: SOLR-1777.patch
>
>
> field types with the sortMissingLast=true attribute can have results sorted incorrectly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-1777) fields with sortMissingLast don't sort
correctly
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley resolved SOLR-1777.
--------------------------------
Resolution: Fixed
Fix Version/s: 1.5
committed.
> fields with sortMissingLast don't sort correctly
> ------------------------------------------------
>
> Key: SOLR-1777
> URL: https://issues.apache.org/jira/browse/SOLR-1777
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.4
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Priority: Critical
> Fix For: 1.5
>
> Attachments: SOLR-1777.patch, SOLR-1777.patch
>
>
> field types with the sortMissingLast=true attribute can have results sorted incorrectly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1777) fields with sortMissingLast don't sort
correctly
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley updated SOLR-1777:
-------------------------------
Attachment: SOLR-1777.patch
OK, here's the final patch with all tests passing.
> fields with sortMissingLast don't sort correctly
> ------------------------------------------------
>
> Key: SOLR-1777
> URL: https://issues.apache.org/jira/browse/SOLR-1777
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.4
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Priority: Critical
> Attachments: SOLR-1777.patch, SOLR-1777.patch
>
>
> field types with the sortMissingLast=true attribute can have results sorted incorrectly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1777) fields with sortMissingLast don't
sort correctly
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835937#action_12835937 ]
Yonik Seeley commented on SOLR-1777:
------------------------------------
bq. Correction: Tom Hill and I have seen this bug in the distant past on Solr 1.2 or 1.3.
Then it was a different bug. This code was all new for 1.4
Was it reproducible, and was a bug report filed? Can it still be reproduced?
> fields with sortMissingLast don't sort correctly
> ------------------------------------------------
>
> Key: SOLR-1777
> URL: https://issues.apache.org/jira/browse/SOLR-1777
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.4
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Priority: Critical
> Fix For: 1.5
>
> Attachments: SOLR-1777.patch, SOLR-1777.patch
>
>
> field types with the sortMissingLast=true attribute can have results sorted incorrectly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1777) fields with sortMissingLast don't
sort correctly
Posted by "Lance Norskog (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835936#action_12835936 ]
Lance Norskog commented on SOLR-1777:
-------------------------------------
Correction: Tom Hill and I have seen this bug in the distant past on Solr 1.2 or 1.3.
> fields with sortMissingLast don't sort correctly
> ------------------------------------------------
>
> Key: SOLR-1777
> URL: https://issues.apache.org/jira/browse/SOLR-1777
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.4
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Priority: Critical
> Fix For: 1.5
>
> Attachments: SOLR-1777.patch, SOLR-1777.patch
>
>
> field types with the sortMissingLast=true attribute can have results sorted incorrectly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1777) fields with sortMissingLast don't
sort correctly
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835451#action_12835451 ]
Yonik Seeley commented on SOLR-1777:
------------------------------------
bq. Yonik: just to be verify: was this bug was introduced in Solr 1.4?... presumably because of the changes to per segment collecting?
Yep. The per-segment collecting and the FieldComparator changes caused us to rewrite all of our custom comparators... and this one had bugs.
> fields with sortMissingLast don't sort correctly
> ------------------------------------------------
>
> Key: SOLR-1777
> URL: https://issues.apache.org/jira/browse/SOLR-1777
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.4
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Priority: Critical
> Fix For: 1.5
>
> Attachments: SOLR-1777.patch, SOLR-1777.patch
>
>
> field types with the sortMissingLast=true attribute can have results sorted incorrectly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1777) fields with sortMissingLast don't
sort correctly
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835424#action_12835424 ]
Hoss Man commented on SOLR-1777:
--------------------------------
Yonik: just to be verify: was this bug was introduced in Solr 1.4? ... presumably because of the changes to per segment collecting?
(that's the way the "Affects Version/s" is marked, but i want to sanity check in case it was actually a more fundamental problem affecting earlier versions of Solr as well).
> fields with sortMissingLast don't sort correctly
> ------------------------------------------------
>
> Key: SOLR-1777
> URL: https://issues.apache.org/jira/browse/SOLR-1777
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.4
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Priority: Critical
> Fix For: 1.5
>
> Attachments: SOLR-1777.patch, SOLR-1777.patch
>
>
> field types with the sortMissingLast=true attribute can have results sorted incorrectly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1777) fields with sortMissingLast don't sort
correctly
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley updated SOLR-1777:
-------------------------------
Attachment: SOLR-1777.patch
The issue had to do with ords and ord normalization in sort-missing-last.
Here's a patch with tests and a rewritten MissingLastOrdComparator that manipulates ord values rather than trying to just handle nulls.
> fields with sortMissingLast don't sort correctly
> ------------------------------------------------
>
> Key: SOLR-1777
> URL: https://issues.apache.org/jira/browse/SOLR-1777
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.4
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Priority: Critical
> Attachments: SOLR-1777.patch
>
>
> field types with the sortMissingLast=true attribute can have results sorted incorrectly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.