[jira] [Commented] (GEODE-10331) DistributionImpl.destroyMember keeps cache alive for some number of seconds

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606439#comment-17606439 ] 

ASF subversion and git services commented on GEODE-10331:
---------------------------------------------------------

Commit 7d7a98b10355cb25985c031bfd2a67c77f1b6e43 in geode's branch refs/heads/develop from Mario Ivanac
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=7d7a98b103 ]

GEODE-10331: schedule delayed CloseEndpoint (#7849)

* GEODE-10331: schedule delayed CloseEndpoint

* GEODE-10331: added TCs

> DistributionImpl.destroyMember keeps cache alive for some number of seconds
> ---------------------------------------------------------------------------
>
>                 Key: GEODE-10331
>                 URL: https://issues.apache.org/jira/browse/GEODE-10331
>             Project: Geode
>          Issue Type: Bug
>          Components: membership
>            Reporter: Darrel Schneider
>            Assignee: Mario Ivanac
>            Priority: Major
>              Labels: blocks-1.16.0, pull-request-available
>
> org.apache.geode.distributed.internal.DistributionImpl.destroyMember creates a thread that will hold onto the DIstributesSystem/Cache through the DirectChannel it has for 3 seconds by default. It could be even longer if p2p.disconnectDelay is set to a value > 3000.
> This can be a problem if the JVM is trying to reconnect since this old cache uses memory.
> Instead of creating a new thread for every call of destroyMember, we should just have a single ScheduledExecutor that we schedule the background "closeEndpoint" with.
> Also since all this code interacts with the DirectChannel all the logic about the executor and scheduling it should belong to DirectChannel, not the DistributionImpl.
> When the DirectChannel has disconnect called on it, then it should get rid of all the tasks scheduled in the executor since they are no longer needed.
> I think this issue has been around for a long time because the creation of the thread refers to fixing "Bug 37944" which is on old bug system that is not longer used for geode.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)