You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/01/07 09:29:04 UTC

[GitHub] [incubator-tvm] yuliujq commented on a change in pull request #4620: [Bugfix] fskip of EliminateCommonSubexpr cannot always return false

yuliujq commented on a change in pull request #4620: [Bugfix] fskip of EliminateCommonSubexpr cannot always return false
URL: https://github.com/apache/incubator-tvm/pull/4620#discussion_r363659261
 
 

 ##########
 File path: src/relay/backend/build_module.cc
 ##########
 @@ -318,6 +318,7 @@ class RelayBuildModule : public runtime::ModuleNode {
     pass_seqs.push_back(transform::SimplifyInference());
     PackedFunc fskip = PackedFunc([](TVMArgs args, TVMRetValue* rv) {
       Expr expr = args[0];
+      *rv = false;
 
 Review comment:
   Default return false

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services