You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/06/30 05:50:31 UTC
[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #698: Check sanitizer status for TCL tests in CI
tisonkun commented on code in PR #698:
URL: https://github.com/apache/incubator-kvrocks/pull/698#discussion_r910628178
##########
.github/workflows/kvrocks.yaml:
##########
@@ -145,7 +145,11 @@ jobs:
- name: Run Redis Tcl Test
run: |
cp $HOME/local/bin/redis-cli tests/tcl/redis-cli
- cd tests/tcl && ./runtest
+ cd tests/tcl
+ ./runtest --dont-clean
+ SANITIZER_OUTPUT=$(grep "Sanitizer:" tests/tmp -r)
+ echo $SANITIZER_OUTPUT
+ if [[ $SANITIZER_OUTPUT ]]; then exit 1; fi
Review Comment:
I'd prefer to echo output in the `if` block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org