You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metamodel.apache.org by "Jamie goodyear (JIRA)" <ji...@apache.org> on 2017/10/22 20:11:00 UTC

[jira] [Updated] (METAMODEL-1168) MetaModelHelper getGrouped API call triggers a StackOverflow

     [ https://issues.apache.org/jira/browse/METAMODEL-1168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jamie goodyear updated METAMODEL-1168:
--------------------------------------
    Description: 
MetaModelHelper getGrouped public method:

{quote}
public static DataSet getGrouped(List<SelectItem> selectItems, DataSet dataSet,
            Collection<GroupByItem> groupByItems) {
        return getGrouped(selectItems, dataSet, groupByItems);
}
{quote}

When this API is called:
{quote}
public void testGetGroupedByCollection() {
        List<SelectItem> selectItems = new ArrayList<>();
        DataSet inputDataSet = null;
        Collection<GroupByItem> groupByItemCollection = null;
        DataSet dataSet = MetaModelHelper.getGrouped(selectItems, inputDataSet, groupByItemCollection);
        assertNotNull(dataSet);
}
{quote}

It results in a Stackoverflow:
{quote}
Tests in error: 
  MetaModelHelperTest.testGetGroupedByCollection » StackOverflow
{quote}

This call should either be removed, or altered to break the recursive loop.

Was the intent to convert "Collection<GroupByItem>" to a List<GroupByItem> for calling that getGrouped signature?

  was:

MetaModelHelper getGrouped public method:

{{public static DataSet getGrouped(List<SelectItem> selectItems, DataSet dataSet,
            Collection<GroupByItem> groupByItems) {
        return getGrouped(selectItems, dataSet, groupByItems);
}}}

When this API is called:

{{public void testGetGroupedByCollection() {
        List<SelectItem> selectItems = new ArrayList<>();
        DataSet inputDataSet = null;
        Collection<GroupByItem> groupByItemCollection = null;
        DataSet dataSet = MetaModelHelper.getGrouped(selectItems, inputDataSet, groupByItemCollection);
        assertNotNull(dataSet);
}}}

It results in a Stackoverflow:
{{Tests in error: 
  MetaModelHelperTest.testGetGroupedByCollection » StackOverflow}}

This call should either be removed, or altered to break the recursive loop.

Was the intent to convert "Collection<GroupByItem>" to a List<GroupByItem> for calling that getGrouped signature?


> MetaModelHelper getGrouped API call triggers a StackOverflow
> ------------------------------------------------------------
>
>                 Key: METAMODEL-1168
>                 URL: https://issues.apache.org/jira/browse/METAMODEL-1168
>             Project: Apache MetaModel
>          Issue Type: Bug
>    Affects Versions: 5.0.0
>            Reporter: Jamie goodyear
>
> MetaModelHelper getGrouped public method:
> {quote}
> public static DataSet getGrouped(List<SelectItem> selectItems, DataSet dataSet,
>             Collection<GroupByItem> groupByItems) {
>         return getGrouped(selectItems, dataSet, groupByItems);
> }
> {quote}
> When this API is called:
> {quote}
> public void testGetGroupedByCollection() {
>         List<SelectItem> selectItems = new ArrayList<>();
>         DataSet inputDataSet = null;
>         Collection<GroupByItem> groupByItemCollection = null;
>         DataSet dataSet = MetaModelHelper.getGrouped(selectItems, inputDataSet, groupByItemCollection);
>         assertNotNull(dataSet);
> }
> {quote}
> It results in a Stackoverflow:
> {quote}
> Tests in error: 
>   MetaModelHelperTest.testGetGroupedByCollection » StackOverflow
> {quote}
> This call should either be removed, or altered to break the recursive loop.
> Was the intent to convert "Collection<GroupByItem>" to a List<GroupByItem> for calling that getGrouped signature?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)