You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by cguzel <gi...@git.apache.org> on 2016/05/22 20:05:01 UTC
[GitHub] gora pull request: GORA-465 remove deprecated logic
GitHub user cguzel opened a pull request:
https://github.com/apache/gora/pull/67
GORA-465 remove deprecated logic
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cguzel/gora GORA-465
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/gora/pull/67.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #67
----
commit afbc68e6669f0b566eaf05c8872d45ee1bc4db17
Author: cihad guzel <cg...@gmail.com>
Date: 2016-05-22T19:56:08Z
GORA-465 remove deprecated logic
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-465 remove deprecated logic
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/gora/pull/67
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-465 remove deprecated logic
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the pull request:
https://github.com/apache/gora/pull/67#issuecomment-221010667
@cguzel PING
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-465 remove deprecated logic
Posted by cguzel <gi...@git.apache.org>.
Github user cguzel commented on a diff in the pull request:
https://github.com/apache/gora/pull/67#discussion_r64287443
--- Diff: gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java ---
@@ -116,18 +114,8 @@ public void initialize(Class<K> keyClass, Class<T> persistentClass,
mapping = readMapping(getConf().get(PARSE_MAPPING_FILE_KEY, DEFAULT_MAPPING_FILE));
filterUtil = new HBaseFilterUtil<>(this.conf);
} catch (FileNotFoundException ex) {
- try {
- mapping = readMapping(getConf().get(PARSE_MAPPING_FILE_KEY, DEPRECATED_MAPPING_FILE));
- LOG.warn(DEPRECATED_MAPPING_FILE + " is deprecated, please rename the file to "
- + DEFAULT_MAPPING_FILE);
- } catch (FileNotFoundException ex1) {
- LOG.error(ex1.getMessage(), ex1);
- //throw (ex1); //throw the original exception
- } catch (Exception ex1) {
- LOG.warn(DEPRECATED_MAPPING_FILE + " is deprecated, please rename the file to "
- + DEFAULT_MAPPING_FILE);
- throw new RuntimeException(ex1);
- }
+ LOG.error(DEFAULT_MAPPING_FILE + " is not found, please check the file.");
--- End diff --
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-465 remove deprecated logic
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/gora/pull/67#discussion_r64160518
--- Diff: gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java ---
@@ -116,18 +114,8 @@ public void initialize(Class<K> keyClass, Class<T> persistentClass,
mapping = readMapping(getConf().get(PARSE_MAPPING_FILE_KEY, DEFAULT_MAPPING_FILE));
filterUtil = new HBaseFilterUtil<>(this.conf);
} catch (FileNotFoundException ex) {
- try {
- mapping = readMapping(getConf().get(PARSE_MAPPING_FILE_KEY, DEPRECATED_MAPPING_FILE));
- LOG.warn(DEPRECATED_MAPPING_FILE + " is deprecated, please rename the file to "
- + DEFAULT_MAPPING_FILE);
- } catch (FileNotFoundException ex1) {
- LOG.error(ex1.getMessage(), ex1);
- //throw (ex1); //throw the original exception
- } catch (Exception ex1) {
- LOG.warn(DEPRECATED_MAPPING_FILE + " is deprecated, please rename the file to "
- + DEFAULT_MAPPING_FILE);
- throw new RuntimeException(ex1);
- }
+ LOG.error(DEFAULT_MAPPING_FILE + " is not found, please check the file.");
--- End diff --
Can you please use the paramaterized slf4j logging notation here? e.g.
```
+ LOG.error("{} is not found, please check the file.", DEFAULT_MAPPING_FILE);
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---