You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/03/11 02:08:23 UTC

[GitHub] [echarts] plainheart opened a new pull request #14448: tweak(line): tweak default line bolder logic.

plainheart opened a new pull request #14448:
URL: https://github.com/apache/echarts/pull/14448


   
   
   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [ ] new feature
   - [x] others
   
   
   
   ### What does this PR do?
   
   <!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   This PR is intended to tweak the default bolder logic of the line series.
   
   - The line **won't** be bolder again in emphasis state by default
   - Only make line bolder when there are more than one series and blur state
   - Or the user manually specify `lineStyle.width` as `bolder`
   
   Please refer to #13501 and #13013 for more details.
   
   ### Fixed issues
   
   - https://github.com/apache/echarts/pull/13501#issuecomment-717771672
   
   
   ## Details
   
   ### Before: What was the problem?
   
   <!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   It's unnecessary for some cases to make the line bolder.
   `bolder` is more suitable for multiple series with the blur scope.
   
   ### After: How is it fixed in this PR?
   
   <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   See above.
   
   ## Usage
   
   ### Are there any API changes?
   
   - [x] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   The new semantic value `bolder` for `emphasis.lineStyle.width` brought by #13013 has not been added to the document yet.
   
   ### Related test cases or examples to use the new APIs
   
   `test/area-large.html`
   `test/line-boldWhenHover.html`
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] plainheart closed pull request #14448: tweak(line): tweak default line bolder logic.

Posted by GitBox <gi...@apache.org>.
plainheart closed pull request #14448:
URL: https://github.com/apache/echarts/pull/14448


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #14448: tweak(line): tweak default line bolder logic.

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14448:
URL: https://github.com/apache/echarts/pull/14448#issuecomment-796373880


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.
   
   Document changes are required in this PR. Please also make a PR to [apache/echarts-doc](https://github.com/apache/echarts-doc) for document changes. When the doc PR is merged, the maintainers will remove the `PR: awaiting doc` label.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org