You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/02/24 14:11:50 UTC
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2201:
Add base62 encoder/decoder
apache-mynewt-bot removed a comment on issue #2201: Add base62 encoder/decoder
URL: https://github.com/apache/mynewt-core/pull/2201#issuecomment-590308631
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### encoding/base62/selftest/src/encoding_test.c
<details>
```diff
@@ -25,8 +25,7 @@
TEST_CASE_DECL(base62_encoding)
TEST_CASE_DECL(base62_errors)
-TEST_SUITE(base62_test_suite)
-{
+TEST_SUITE(base62_test_suite) {
base62_invalid_args();
base62_encoding();
base62_errors();
```
</details>
#### encoding/base62/src/base62.c
<details>
```diff
@@ -28,7 +28,7 @@
/**
* Function to convert symbol from encoded text to it's ordinal number.
-*/
+ */
typedef int decode_symbol_t(uint8_t digit_symbol);
static int
@@ -139,17 +139,17 @@
}
int
-base62_encode(const void* data, unsigned int input_size,
- char* encoded_text, unsigned int* output_size)
+base62_encode(const void * data, unsigned int input_size,
+ char * encoded_text, unsigned int * output_size)
{
return base_n_encode(data, input_size, 256, decode_256,
- 62, encode_62, (uint8_t*)encoded_text, output_size);
+ 62, encode_62, (uint8_t *)encoded_text, output_size);
}
int
-base62_decode(const char* encoded_text, unsigned int length,
- void* output_data, unsigned int* output_size)
+base62_decode(const char * encoded_text, unsigned int length,
+ void * output_data, unsigned int * output_size)
{
- return base_n_encode((const uint8_t*)encoded_text, length, 62, decode_62,
+ return base_n_encode((const uint8_t *)encoded_text, length, 62, decode_62,
256, encode_256, output_data, output_size);
}
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services