You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Russole (via GitHub)" <gi...@apache.org> on 2025/12/25 02:17:31 UTC

[PR] HDDS-13818. Remove dnsjava.version [ozone]

Russole opened a new pull request, #9557:
URL: https://github.com/apache/ozone/pull/9557

   ## What changes were proposed in this pull request?
   * Removed explicit `dnsjava` dependency and version definition from the Ozone root POM.
   * Removed `dnsjava` exclusions to allow it to be resolved via Hadoop-managed dependencies.
   * Aligned Ozone dependency management with Hadoop, since Ozone does not directly depend on `dnsjava`.
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-13818
   ## How was this patch tested?
   I relied on existing unit and integration tests, and verified that the full CI passed on my fork.
   Please let me know if additional tests are needed.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-13818. Remove dnsjava.version [ozone]

Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on PR #9557:
URL: https://github.com/apache/ozone/pull/9557#issuecomment-3691398956

   @Russole thanks for the patch!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-13818. Remove dnsjava.version [ozone]

Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on PR #9557:
URL: https://github.com/apache/ozone/pull/9557#issuecomment-3693978048

   thanks @Russole , @echonesis , @adoroszlai !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-13818. Remove dnsjava.version [ozone]

Posted by "Russole (via GitHub)" <gi...@apache.org>.
Russole commented on PR #9557:
URL: https://github.com/apache/ozone/pull/9557#issuecomment-3693235237

   Thanks @rich7420 and @adoroszlai for the reviews.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-13818. Remove dnsjava.version [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #9557:
URL: https://github.com/apache/ozone/pull/9557#issuecomment-3693894258

   Thanks @Russole for the patch, @echonesis, @rich7420 for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-13818. Remove dnsjava.version [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #9557:
URL: https://github.com/apache/ozone/pull/9557#discussion_r2648117969


##########
hadoop-hdds/hadoop-dependency-client/pom.xml:
##########
@@ -112,10 +112,6 @@
             <groupId>commons-net</groupId>
             <artifactId>commons-net</artifactId>
           </exclusion>
-          <exclusion>
-            <groupId>dnsjava</groupId>
-            <artifactId>dnsjava</artifactId>
-          </exclusion>

Review Comment:
   This should not be removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-13818. Remove dnsjava.version [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #9557:
URL: https://github.com/apache/ozone/pull/9557


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org