You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/06 00:45:52 UTC

[GitHub] [superset] danielewood opened a new pull request #15007: Fix(docker/helm): Make webserver query timeout adjustable

danielewood opened a new pull request #15007:
URL: https://github.com/apache/superset/pull/15007


   ### SUMMARY
   We have long running dashboard queries (2-3 minutes) which were getting tripped up by the 60 second timeout with 504 Gateway Timeout.
   
   I modified the dockerfile to keep the default 60 second timeout on gunicorn, but allow GUNICORN_TIMEOUT env to override.
   
   I also modified the values.yml to provide the needed placeholders to implementing a longer timeout at gunicorn, superset_webserver_timeout, and the nginx proxy timeout. 
   
   Note: This change is non-disruptive, no end user will be impacted unless they turn on settings in the values.yaml.
   
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   1. Run a query on a dashboard that takes longer than 60 seconds, watch it time out.
   2. Apply patch, enable new helm lines, do same query, watch it work.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org