You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/12 17:43:12 UTC

[GitHub] [pulsar] nha opened a new pull request #8548: [Issue 8547][java-client] new listener for end of topic events

nha opened a new pull request #8548:
URL: https://github.com/apache/pulsar/pull/8548


   Fixes #8547
   
   
   ### Motivation
   
   I am using the java client and calling `consumer.receive()` or `consumer.receiveAsync()` to get messages. This is incompatible with the end of topic listener.
   Here I create a new listener `EndOfTopicListener` that can be used without having to receive messages, unlike the existing `MessageListener`.
   
   ### Modifications
   
   I allow passing a `endOfTopicMessageListener` to the consumerBuilder, and pass the data along to the consumer implementation which will call the listener accordingly.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: yes 
     - The schema: no
     - The default values of configurations: no
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: no
   
   ### Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? JavaDocs
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nha closed pull request #8548: [Issue 8547][java-client] new listener for end of topic events

Posted by GitBox <gi...@apache.org>.
nha closed pull request #8548:
URL: https://github.com/apache/pulsar/pull/8548


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org