You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/25 10:23:22 UTC

[GitHub] [arrow] cyb70289 commented on a change in pull request #12239: ARROW-15374: [C++][FlightRPC] Add support for MemoryManager in data methods

cyb70289 commented on a change in pull request #12239:
URL: https://github.com/apache/arrow/pull/12239#discussion_r791564011



##########
File path: cpp/src/arrow/flight/client.cc
##########
@@ -460,6 +462,11 @@ class GrpcIpcMessageReader : public ipc::MessageReader {
       stream_finished_ = true;
       return stream_->Finish(Status::OK());
     }
+
+    if (ARROW_PREDICT_FALSE(!memory_manager_->is_cpu() && data->body)) {
+      ARROW_ASSIGN_OR_RAISE(data->body, Buffer::ViewOrCopy(data->body, memory_manager_));
+    }

Review comment:
       Nit: Does it make sense to move this code inside peekable_reader_->Next()?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org