You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "FlechazoW (via GitHub)" <gi...@apache.org> on 2023/03/27 01:17:37 UTC

[GitHub] [hudi] FlechazoW opened a new pull request, #8297: [Improve][Hoodie Source] Replace 'obj == null' with Optional.ofNullable(), make the code more standardized.

FlechazoW opened a new pull request, #8297:
URL: https://github.com/apache/hudi/pull/8297

   
   ### Change Logs
   
   _Describe context and summary for this change. Highlight if any code was copied._
   
   Replace 'obj == null' with Optional.ofNullable(), make the code more standardized.
   
   ### Impact
   
   _Describe any public API or user-facing feature change or any performance impact._
   
   ### Risk level (write none, low medium or high below)
   
   _If medium or high, explain what verification was done to mitigate the risks._
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8297: [MINOR] Replace 'obj == null' with Optional.ofNullable() in HoodieTableSource, make the code more standardized

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8297:
URL: https://github.com/apache/hudi/pull/8297#issuecomment-1732470582

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e40305ee1bedde0837b28363a9da304aa09a249e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15933",
       "triggerID" : "e40305ee1bedde0837b28363a9da304aa09a249e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1779c99e041e709840c8ada8f1101c5e507f61fc",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1779c99e041e709840c8ada8f1101c5e507f61fc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e40305ee1bedde0837b28363a9da304aa09a249e Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15933) 
   * 1779c99e041e709840c8ada8f1101c5e507f61fc UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8297: [MINOR] Replace 'obj == null' with Optional.ofNullable() in HoodieTableSource, make the code more standardized

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8297:
URL: https://github.com/apache/hudi/pull/8297#issuecomment-1732471968

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e40305ee1bedde0837b28363a9da304aa09a249e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15933",
       "triggerID" : "e40305ee1bedde0837b28363a9da304aa09a249e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1779c99e041e709840c8ada8f1101c5e507f61fc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20116",
       "triggerID" : "1779c99e041e709840c8ada8f1101c5e507f61fc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e40305ee1bedde0837b28363a9da304aa09a249e Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15933) 
   * 1779c99e041e709840c8ada8f1101c5e507f61fc Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20116) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8297: [Improve][Hoodie Source] Replace 'obj == null' with Optional.ofNullable(), make the code more standardized.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8297:
URL: https://github.com/apache/hudi/pull/8297#issuecomment-1484336986

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e40305ee1bedde0837b28363a9da304aa09a249e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e40305ee1bedde0837b28363a9da304aa09a249e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e40305ee1bedde0837b28363a9da304aa09a249e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8297: [Improve][Hoodie Source] Replace 'obj == null' with Optional.ofNullable(), make the code more standardized.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8297:
URL: https://github.com/apache/hudi/pull/8297#issuecomment-1484467294

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e40305ee1bedde0837b28363a9da304aa09a249e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15933",
       "triggerID" : "e40305ee1bedde0837b28363a9da304aa09a249e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e40305ee1bedde0837b28363a9da304aa09a249e Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15933) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8297: [MINOR] Replace 'obj == null' with Optional.ofNullable() in HoodieTableSource, make the code more standardized

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8297:
URL: https://github.com/apache/hudi/pull/8297#issuecomment-1732670310

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1779c99e041e709840c8ada8f1101c5e507f61fc",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20116",
       "triggerID" : "1779c99e041e709840c8ada8f1101c5e507f61fc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1779c99e041e709840c8ada8f1101c5e507f61fc Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20116) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8297: [Improve][Hoodie Source] Replace 'obj == null' with Optional.ofNullable(), make the code more standardized.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8297:
URL: https://github.com/apache/hudi/pull/8297#issuecomment-1484379126

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e40305ee1bedde0837b28363a9da304aa09a249e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15933",
       "triggerID" : "e40305ee1bedde0837b28363a9da304aa09a249e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e40305ee1bedde0837b28363a9da304aa09a249e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15933) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8297: [MINOR] Replace 'obj == null' with Optional.ofNullable() in HoodieTableSource, make the code more standardized

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8297:
URL: https://github.com/apache/hudi/pull/8297#issuecomment-1732645993

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1779c99e041e709840c8ada8f1101c5e507f61fc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20116",
       "triggerID" : "1779c99e041e709840c8ada8f1101c5e507f61fc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1779c99e041e709840c8ada8f1101c5e507f61fc Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20116) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8297: [MINOR] Replace 'obj == null' with Optional.ofNullable() in HoodieTableSource, make the code more standardized

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8297:
URL: https://github.com/apache/hudi/pull/8297#issuecomment-1732644204

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1779c99e041e709840c8ada8f1101c5e507f61fc",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1779c99e041e709840c8ada8f1101c5e507f61fc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1779c99e041e709840c8ada8f1101c5e507f61fc UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua merged pull request #8297: [MINOR] Replace 'obj == null' with Optional.ofNullable() in HoodieTableSource, make the code more standardized

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #8297:
URL: https://github.com/apache/hudi/pull/8297


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8297: [MINOR] Replace 'obj == null' with Optional.ofNullable() in HoodieTableSource, make the code more standardized

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8297:
URL: https://github.com/apache/hudi/pull/8297#issuecomment-1732504032

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e40305ee1bedde0837b28363a9da304aa09a249e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15933",
       "triggerID" : "e40305ee1bedde0837b28363a9da304aa09a249e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1779c99e041e709840c8ada8f1101c5e507f61fc",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20116",
       "triggerID" : "1779c99e041e709840c8ada8f1101c5e507f61fc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1779c99e041e709840c8ada8f1101c5e507f61fc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20116) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] FlechazoW commented on pull request #8297: [Improve][Hoodie Source] Replace 'obj == null' with Optional.ofNullable(), make the code more standardized.

Posted by "FlechazoW (via GitHub)" <gi...@apache.org>.
FlechazoW commented on PR #8297:
URL: https://github.com/apache/hudi/pull/8297#issuecomment-1489899035

   @danny0405 cc. PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org