You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Sean Busbey (JIRA)" <ji...@apache.org> on 2014/08/05 15:15:11 UTC
[jira] [Created] (HBASE-11677) Make Logger instance modifiers
consistent
Sean Busbey created HBASE-11677:
-----------------------------------
Summary: Make Logger instance modifiers consistent
Key: HBASE-11677
URL: https://issues.apache.org/jira/browse/HBASE-11677
Project: HBase
Issue Type: Task
Reporter: Sean Busbey
Priority: Minor
We have some instances of Logger that are missing one of being private, static, and final.
ex from HealthChecker.java, missing final
{code}
private static Log LOG = LogFactory.getLog(HealthChecker.class);
{code}
* Clean up where possible by making {{private static final}}
* If we can't, add a non-javadoc note about why
One way to look for problematic instances is to grep for initial assignment for the commonly used LOG member, e.g.
* missing final: {{grep -r "LOG =" * | grep -v "final"}}
* missing static: {{grep -r "LOG =" * | grep -v "static"}}
* missing private: {{grep -r "LOG =" * | grep -v "private"}}
--
This message was sent by Atlassian JIRA
(v6.2#6252)