You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ol...@apache.org on 2011/12/27 18:36:20 UTC

svn commit: r1224955 - /tomcat/sandbox/trunk-mvn-build/tomcat-tests/src/test/java/org/apache/catalina/authenticator/TestFormAuthenticator.java

Author: olamy
Date: Tue Dec 27 17:36:19 2011
New Revision: 1224955

URL: http://svn.apache.org/viewvc?rev=1224955&view=rev
Log:
fix path

Modified:
    tomcat/sandbox/trunk-mvn-build/tomcat-tests/src/test/java/org/apache/catalina/authenticator/TestFormAuthenticator.java

Modified: tomcat/sandbox/trunk-mvn-build/tomcat-tests/src/test/java/org/apache/catalina/authenticator/TestFormAuthenticator.java
URL: http://svn.apache.org/viewvc/tomcat/sandbox/trunk-mvn-build/tomcat-tests/src/test/java/org/apache/catalina/authenticator/TestFormAuthenticator.java?rev=1224955&r1=1224954&r2=1224955&view=diff
==============================================================================
--- tomcat/sandbox/trunk-mvn-build/tomcat-tests/src/test/java/org/apache/catalina/authenticator/TestFormAuthenticator.java (original)
+++ tomcat/sandbox/trunk-mvn-build/tomcat-tests/src/test/java/org/apache/catalina/authenticator/TestFormAuthenticator.java Tue Dec 27 17:36:19 2011
@@ -106,7 +106,7 @@ public class TestFormAuthenticator exten
 
         private FormAuthClient() throws Exception {
             Tomcat tomcat = getTomcatInstance();
-            File appDir = new File(getBuildDirectory(), "webapps/examples");
+            File appDir = new File(getBuildDirectory(), "/examples");
             Context ctx = tomcat.addWebapp(null, "/examples",
                     appDir.getAbsolutePath());
 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1224955 - /tomcat/sandbox/trunk-mvn-build/tomcat-tests/src/test/java/org/apache/catalina/authenticator/TestFormAuthenticator.java

Posted by Konstantin Kolinko <kn...@gmail.com>.
2011/12/27 Olivier Lamy <ol...@apache.org>:
> 2011/12/27 Konstantin Kolinko <kn...@gmail.com>:
>> 2011/12/27  <ol...@apache.org>:
>>> Author: olamy
>>> Date: Tue Dec 27 17:36:19 2011
>>> New Revision: 1224955
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1224955&view=rev
>>> Log:
>>> fix path
>>>
>>> Modified:
>>>    tomcat/sandbox/trunk-mvn-build/tomcat-tests/src/test/java/org/apache/catalina/authenticator/TestFormAuthenticator.java
>>>
>>>
>>>         private FormAuthClient() throws Exception {
>>>             Tomcat tomcat = getTomcatInstance();
>>> -            File appDir = new File(getBuildDirectory(), "webapps/examples");
>>> +            File appDir = new File(getBuildDirectory(), "/examples");
>>
>> Are you on Linux? The above should be just "examples".
> yes.
> See change in getBuildDirectory() (return "target")
> As with a maven structure, the examples webapp is now on his own
> project, the war is expanded before test phase to target/examples and
> various resources are available in this path.

I just mean s/ "/examples" / "examples" / without the leading slash in
the relative filesystem path.

(To my surprise the current code works. I mean concatenation of paths
just ignores the leading '/', not honoring the path concatenation
rules of the OS. Well, that has a reason.)

>
>>
>>>             Context ctx = tomcat.addWebapp(null, "/examples",
>>>                     appDir.getAbsolutePath());
>>>

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1224955 - /tomcat/sandbox/trunk-mvn-build/tomcat-tests/src/test/java/org/apache/catalina/authenticator/TestFormAuthenticator.java

Posted by Olivier Lamy <ol...@apache.org>.
2011/12/27 Konstantin Kolinko <kn...@gmail.com>:
> 2011/12/27  <ol...@apache.org>:
>> Author: olamy
>> Date: Tue Dec 27 17:36:19 2011
>> New Revision: 1224955
>>
>> URL: http://svn.apache.org/viewvc?rev=1224955&view=rev
>> Log:
>> fix path
>>
>> Modified:
>>    tomcat/sandbox/trunk-mvn-build/tomcat-tests/src/test/java/org/apache/catalina/authenticator/TestFormAuthenticator.java
>>
>>
>>         private FormAuthClient() throws Exception {
>>             Tomcat tomcat = getTomcatInstance();
>> -            File appDir = new File(getBuildDirectory(), "webapps/examples");
>> +            File appDir = new File(getBuildDirectory(), "/examples");
>
> Are you on Linux? The above should be just "examples".
yes.
See change in getBuildDirectory() (return "target")
As with a maven structure, the examples webapp is now on his own
project, the war is expanded before test phase to target/examples and
various resources are available in this path.

>
>>             Context ctx = tomcat.addWebapp(null, "/examples",
>>                     appDir.getAbsolutePath());
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>



-- 
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1224955 - /tomcat/sandbox/trunk-mvn-build/tomcat-tests/src/test/java/org/apache/catalina/authenticator/TestFormAuthenticator.java

Posted by Konstantin Kolinko <kn...@gmail.com>.
2011/12/27  <ol...@apache.org>:
> Author: olamy
> Date: Tue Dec 27 17:36:19 2011
> New Revision: 1224955
>
> URL: http://svn.apache.org/viewvc?rev=1224955&view=rev
> Log:
> fix path
>
> Modified:
>    tomcat/sandbox/trunk-mvn-build/tomcat-tests/src/test/java/org/apache/catalina/authenticator/TestFormAuthenticator.java
>
>
>         private FormAuthClient() throws Exception {
>             Tomcat tomcat = getTomcatInstance();
> -            File appDir = new File(getBuildDirectory(), "webapps/examples");
> +            File appDir = new File(getBuildDirectory(), "/examples");

Are you on Linux? The above should be just "examples".

>             Context ctx = tomcat.addWebapp(null, "/examples",
>                     appDir.getAbsolutePath());
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org