You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ankita Sinha <an...@freestoneinfotech.com> on 2017/03/30 03:32:40 UTC
Review Request 58067: Ranger hive service definition to use hive
metastore directly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58067/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-1483
https://issues.apache.org/jira/browse/RANGER-1483
Repository: ranger
Description
-------
Currently, ranger hive service definition uses hiveserver2(hs2) jdbc driver to fetch hive db/table info, which is used to populate drop downs while creating/updating policies. Adding ranger hive service definition to also use hive metastore client which read from hive metastore db.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java 00374de
hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java 734c8e7
security-admin/pom.xml 77f2b25
security-admin/src/main/webapp/scripts/views/service/ConfigurationList.js dcc85ab
Diff: https://reviews.apache.org/r/58067/diff/1/
Testing
-------
1. Tested on Simple environment.
2. Tested on Secure cluster
3. Tested with SSL
Thanks,
Ankita Sinha
Re: Review Request 58067: Ranger hive service definition to use hive
metastore directly
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58067/#review170738
-----------------------------------------------------------
Ship it!
Ship It!
- Ramesh Mani
On March 31, 2017, 9:15 a.m., Ankita Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58067/
> -----------------------------------------------------------
>
> (Updated March 31, 2017, 9:15 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1483
> https://issues.apache.org/jira/browse/RANGER-1483
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, ranger hive service definition uses hiveserver2(hs2) jdbc driver to fetch hive db/table info, which is used to populate drop downs while creating/updating policies. Adding ranger hive service definition to also use hive metastore client which read from hive metastore db.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java 00374de
> hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java 734c8e7
> security-admin/pom.xml 77f2b25
> security-admin/src/main/webapp/scripts/views/service/ConfigurationList.js dcc85ab
>
>
> Diff: https://reviews.apache.org/r/58067/diff/2/
>
>
> Testing
> -------
>
> 1. Tested on Simple environment.
> 2. Tested on Secure cluster
> 3. Tested with SSL
>
>
> Thanks,
>
> Ankita Sinha
>
>
Re: Review Request 58067: Ranger hive service definition to use hive
metastore directly
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58067/#review170742
-----------------------------------------------------------
Ship it!
Ship It!
- Ramesh Mani
On March 31, 2017, 9:15 a.m., Ankita Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58067/
> -----------------------------------------------------------
>
> (Updated March 31, 2017, 9:15 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1483
> https://issues.apache.org/jira/browse/RANGER-1483
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, ranger hive service definition uses hiveserver2(hs2) jdbc driver to fetch hive db/table info, which is used to populate drop downs while creating/updating policies. Adding ranger hive service definition to also use hive metastore client which read from hive metastore db.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java 00374de
> hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java 734c8e7
> security-admin/pom.xml 77f2b25
> security-admin/src/main/webapp/scripts/views/service/ConfigurationList.js dcc85ab
>
>
> Diff: https://reviews.apache.org/r/58067/diff/2/
>
>
> Testing
> -------
>
> 1. Tested on Simple environment.
> 2. Tested on Secure cluster
> 3. Tested with SSL
>
>
> Thanks,
>
> Ankita Sinha
>
>
Re: Review Request 58067: Ranger hive service definition to use hive
metastore directly
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58067/#review170741
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On March 31, 2017, 9:15 a.m., Ankita Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58067/
> -----------------------------------------------------------
>
> (Updated March 31, 2017, 9:15 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1483
> https://issues.apache.org/jira/browse/RANGER-1483
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, ranger hive service definition uses hiveserver2(hs2) jdbc driver to fetch hive db/table info, which is used to populate drop downs while creating/updating policies. Adding ranger hive service definition to also use hive metastore client which read from hive metastore db.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java 00374de
> hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java 734c8e7
> security-admin/pom.xml 77f2b25
> security-admin/src/main/webapp/scripts/views/service/ConfigurationList.js dcc85ab
>
>
> Diff: https://reviews.apache.org/r/58067/diff/2/
>
>
> Testing
> -------
>
> 1. Tested on Simple environment.
> 2. Tested on Secure cluster
> 3. Tested with SSL
>
>
> Thanks,
>
> Ankita Sinha
>
>
Re: Review Request 58067: Ranger hive service definition to use hive
metastore directly
Posted by Ankita Sinha <an...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58067/
-----------------------------------------------------------
(Updated March 31, 2017, 9:15 a.m.)
Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-1483
https://issues.apache.org/jira/browse/RANGER-1483
Repository: ranger
Description
-------
Currently, ranger hive service definition uses hiveserver2(hs2) jdbc driver to fetch hive db/table info, which is used to populate drop downs while creating/updating policies. Adding ranger hive service definition to also use hive metastore client which read from hive metastore db.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java 00374de
hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java 734c8e7
security-admin/pom.xml 77f2b25
security-admin/src/main/webapp/scripts/views/service/ConfigurationList.js dcc85ab
Diff: https://reviews.apache.org/r/58067/diff/2/
Changes: https://reviews.apache.org/r/58067/diff/1-2/
Testing
-------
1. Tested on Simple environment.
2. Tested on Secure cluster
3. Tested with SSL
Thanks,
Ankita Sinha
Re: Review Request 58067: Ranger hive service definition to use hive
metastore directly
Posted by Ankita Sinha <an...@freestoneinfotech.com>.
> On March 30, 2017, 8:40 p.m., Ramesh Mani wrote:
> > agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java
> > Lines 306 (patched)
> > <https://reviews.apache.org/r/58067/diff/1/?file=1680711#file1680711line306>
> >
> > Do we need this to be set to null explicitly? Null can be its default value when "enableHiveMetastoreLookup" is false.
This is needed as once if hiveSiteFilePath variable is set it presist even if the custom property (hive.site.file.path) is removed in the same context so to handle that scenario we need to set it to null.
- Ankita
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58067/#review170639
-----------------------------------------------------------
On March 30, 2017, 3:32 a.m., Ankita Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58067/
> -----------------------------------------------------------
>
> (Updated March 30, 2017, 3:32 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1483
> https://issues.apache.org/jira/browse/RANGER-1483
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, ranger hive service definition uses hiveserver2(hs2) jdbc driver to fetch hive db/table info, which is used to populate drop downs while creating/updating policies. Adding ranger hive service definition to also use hive metastore client which read from hive metastore db.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java 00374de
> hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java 734c8e7
> security-admin/pom.xml 77f2b25
> security-admin/src/main/webapp/scripts/views/service/ConfigurationList.js dcc85ab
>
>
> Diff: https://reviews.apache.org/r/58067/diff/2/
>
>
> Testing
> -------
>
> 1. Tested on Simple environment.
> 2. Tested on Secure cluster
> 3. Tested with SSL
>
>
> Thanks,
>
> Ankita Sinha
>
>
Re: Review Request 58067: Ranger hive service definition to use hive
metastore directly
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58067/#review170639
-----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java
Lines 76 (patched)
<https://reviews.apache.org/r/58067/#comment243517>
Please move this along with other boolean variable declaration as coding practice.
Do this for other class also where you declared similar boolean variables.
agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java
Lines 306 (patched)
<https://reviews.apache.org/r/58067/#comment243515>
Do we need this to be set to null explicitly? Null can be its default value when "enableHiveMetastoreLookup" is false.
hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java
Lines 602 (patched)
<https://reviews.apache.org/r/58067/#comment243511>
This Debug message can have the "file path"? please review other similar error message have "filepath" in this debug message.
- Ramesh Mani
On March 30, 2017, 3:32 a.m., Ankita Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58067/
> -----------------------------------------------------------
>
> (Updated March 30, 2017, 3:32 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1483
> https://issues.apache.org/jira/browse/RANGER-1483
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, ranger hive service definition uses hiveserver2(hs2) jdbc driver to fetch hive db/table info, which is used to populate drop downs while creating/updating policies. Adding ranger hive service definition to also use hive metastore client which read from hive metastore db.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java 00374de
> hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java 734c8e7
> security-admin/pom.xml 77f2b25
> security-admin/src/main/webapp/scripts/views/service/ConfigurationList.js dcc85ab
>
>
> Diff: https://reviews.apache.org/r/58067/diff/1/
>
>
> Testing
> -------
>
> 1. Tested on Simple environment.
> 2. Tested on Secure cluster
> 3. Tested with SSL
>
>
> Thanks,
>
> Ankita Sinha
>
>