You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/15 17:40:51 UTC

[GitHub] [spark] imback82 commented on pull request #31825: [SPARK-34699][SQL] 'CREATE OR REPLACE TEMP VIEW USING' should uncache correctly

imback82 commented on pull request #31825:
URL: https://github.com/apache/spark/pull/31825#issuecomment-799613655


   > shall also we clean up the code in `CreateViewCommand`?
   
   Do you mean removing this condition? https://github.com/apache/spark/blob/9809a2f1c5187205c81542dbdc84b71db535f6e1/sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala#L628
   
   If so, I am planning to address it with [SPARK-34700](https://issues.apache.org/jira/browse/SPARK-34700), in which we can change the signature of `getRawTempView`: https://github.com/imback82/spark-4/commit/f1c86b8e97b83d00a50d1e7421e93134c3afb5b8. I can still change it here in this PR, but SPARK-34700 will modify it a bit again. Please let me know which one you prefer. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org