You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltacloud.apache.org by mf...@redhat.com on 2012/08/29 13:24:03 UTC
[PATCH core 3/3] Core: Removed extra quotes from Rack::ETag output
From: Michal Fojtik <mf...@redhat.com>
Signed-off-by: Michal fojtik <mf...@redhat.com>
---
server/lib/sinatra/rack_etag.rb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/lib/sinatra/rack_etag.rb b/server/lib/sinatra/rack_etag.rb
index 14a8cd4..95bcc4e 100644
--- a/server/lib/sinatra/rack_etag.rb
+++ b/server/lib/sinatra/rack_etag.rb
@@ -42,7 +42,7 @@ module Rack
if etag_status?(status) && etag_body?(body) && !http_caching?(headers)
digest, body = digest_body(body)
- headers['ETag'] = %("#{digest}") if digest
+ headers['ETag'] = digest.to_s if digest
end
if not headers['Cache-Control'] and digest
--
1.7.10.2
Re: [PATCH core 3/3] Core: Removed extra quotes from Rack::ETag
output
Posted by David Lutterkort <lu...@redhat.com>.
On Wed, 2012-08-29 at 13:24 +0200, mfojtik@redhat.com wrote:
> From: Michal Fojtik <mf...@redhat.com>
>
>
> Signed-off-by: Michal fojtik <mf...@redhat.com>
> ---
> server/lib/sinatra/rack_etag.rb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Shouldn't that cause a test change, too ? I assume that change was
already folded into 1/3 - doing that destroys bisectability of the tree.
Still ACK (hoping we'll never bisect through this patchset)
David