You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Tony Wu (JIRA)" <ji...@apache.org> on 2007/03/07 16:08:24 UTC

[jira] Created: (HARMONY-3327) [classlib][nio_char]move CharsetProviderTest out from exclude list

[classlib][nio_char]move CharsetProviderTest out from exclude list
------------------------------------------------------------------

                 Key: HARMONY-3327
                 URL: https://issues.apache.org/jira/browse/HARMONY-3327
             Project: Harmony
          Issue Type: Sub-task
          Components: Classlib
            Reporter: Tony Wu


I modified and rewrote some testcases so that it could pass on harmony.

note that 
1. the test/resources/jars/charset_provider.jar has been put into classpath in both cmd line script and eclipse env, so I removed related assertion on this provider.
2. Because harmony has a feature which caches the previous charsets, I combined the testForName_Normal and testIsSupport_Normal into one testcase.
3. the case testIsSupported_InsufficientPrivilege was commented out before. I enabled it and make it passed on Harmony, but it fails on RI. I'll dig out whether we really need this testcase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3327) [classlib][nio_char]move CharsetProviderTest out from exclude list

Posted by "Tony Wu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tony Wu updated HARMONY-3327:
-----------------------------

    Attachment: harmony-3327.diff

patch ready, would you pls try it? thanks a lot!

> [classlib][nio_char]move CharsetProviderTest out from exclude list
> ------------------------------------------------------------------
>
>                 Key: HARMONY-3327
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3327
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Tony Wu
>         Attachments: harmony-3327.diff
>
>
> I modified and rewrote some testcases so that it could pass on harmony.
> note that 
> 1. the test/resources/jars/charset_provider.jar has been put into classpath in both cmd line script and eclipse env, so I removed related assertion on this provider.
> 2. Because harmony has a feature which caches the previous charsets, I combined the testForName_Normal and testIsSupport_Normal into one testcase.
> 3. the case testIsSupported_InsufficientPrivilege was commented out before. I enabled it and make it passed on Harmony, but it fails on RI. I'll dig out whether we really need this testcase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-3327) [classlib][nio_char]move CharsetProviderTest out from exclude list

Posted by "Tony Wu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-3327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481039 ] 

Tony Wu commented on HARMONY-3327:
----------------------------------

verified at r518083, Thanks Richard.

> [classlib][nio_char]move CharsetProviderTest out from exclude list
> ------------------------------------------------------------------
>
>                 Key: HARMONY-3327
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3327
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Tony Wu
>         Assigned To: Richard Liang
>         Attachments: harmony-3327.diff
>
>
> I modified and rewrote some testcases so that it could pass on harmony.
> note that 
> 1. the test/resources/jars/charset_provider.jar has been put into classpath in both cmd line script and eclipse env, so I removed related assertion on this provider.
> 2. Because harmony has a feature which caches the previous charsets, I combined the testForName_Normal and testIsSupport_Normal into one testcase.
> 3. the case testIsSupported_InsufficientPrivilege was commented out before. I enabled it and make it passed on Harmony, but it fails on RI. I'll dig out whether we really need this testcase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-3327) [classlib][nio_char]move CharsetProviderTest out from exclude list

Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Liang resolved HARMONY-3327.
------------------------------------

    Resolution: Fixed

Hello Tony,

The patch has been applied at revision r517540. Thanks a lot for this enhancement, please verify this issue is fixed as you expected.

Best regards,
Richard

> [classlib][nio_char]move CharsetProviderTest out from exclude list
> ------------------------------------------------------------------
>
>                 Key: HARMONY-3327
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3327
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Tony Wu
>         Assigned To: Richard Liang
>         Attachments: harmony-3327.diff
>
>
> I modified and rewrote some testcases so that it could pass on harmony.
> note that 
> 1. the test/resources/jars/charset_provider.jar has been put into classpath in both cmd line script and eclipse env, so I removed related assertion on this provider.
> 2. Because harmony has a feature which caches the previous charsets, I combined the testForName_Normal and testIsSupport_Normal into one testcase.
> 3. the case testIsSupported_InsufficientPrivilege was commented out before. I enabled it and make it passed on Harmony, but it fails on RI. I'll dig out whether we really need this testcase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-3327) [classlib][nio_char]move CharsetProviderTest out from exclude list

Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Liang reassigned HARMONY-3327:
--------------------------------------

    Assignee: Richard Liang

> [classlib][nio_char]move CharsetProviderTest out from exclude list
> ------------------------------------------------------------------
>
>                 Key: HARMONY-3327
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3327
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Tony Wu
>         Assigned To: Richard Liang
>         Attachments: harmony-3327.diff
>
>
> I modified and rewrote some testcases so that it could pass on harmony.
> note that 
> 1. the test/resources/jars/charset_provider.jar has been put into classpath in both cmd line script and eclipse env, so I removed related assertion on this provider.
> 2. Because harmony has a feature which caches the previous charsets, I combined the testForName_Normal and testIsSupport_Normal into one testcase.
> 3. the case testIsSupported_InsufficientPrivilege was commented out before. I enabled it and make it passed on Harmony, but it fails on RI. I'll dig out whether we really need this testcase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3327) [classlib][nio_char]move CharsetProviderTest out from exclude list

Posted by "Tony Wu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tony Wu updated HARMONY-3327:
-----------------------------

    Patch Info: [Patch Available]

> [classlib][nio_char]move CharsetProviderTest out from exclude list
> ------------------------------------------------------------------
>
>                 Key: HARMONY-3327
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3327
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Tony Wu
>         Attachments: harmony-3327.diff
>
>
> I modified and rewrote some testcases so that it could pass on harmony.
> note that 
> 1. the test/resources/jars/charset_provider.jar has been put into classpath in both cmd line script and eclipse env, so I removed related assertion on this provider.
> 2. Because harmony has a feature which caches the previous charsets, I combined the testForName_Normal and testIsSupport_Normal into one testcase.
> 3. the case testIsSupported_InsufficientPrivilege was commented out before. I enabled it and make it passed on Harmony, but it fails on RI. I'll dig out whether we really need this testcase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.