You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by jacques-n <gi...@git.apache.org> on 2016/01/03 02:00:48 UTC
[GitHub] drill pull request: DRILL-4238: Add a custom RPC interface on the ...
GitHub user jacques-n opened a pull request:
https://github.com/apache/drill/pull/313
DRILL-4238: Add a custom RPC interface on the Control channel for extensible communication between bits.
Adds two new interfaces:
- Controller.registerCustomHandler() to register a custom message handler
- ControlTunnel.getCustomTunnel() to send and receive via a custom tunnel (and communicate with custom handlers).
Simple test shows sending and receiving structured messages as well as structured + unstructured messages. As an extensibility point, real uses will come from StoragePlugins, etc.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jacques-n/drill DRILL-4238
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/313.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #313
----
commit d37f1193d7efcd932ef67df1407911a7cf9f6be4
Author: Jacques Nadeau <ja...@apache.org>
Date: 2016-01-03T00:32:36Z
Fix issue where FutureBitComment didn't return buffer as part of future.
commit 7a7bcfa581e11246c941e35e701397c375ff45b0
Author: Jacques Nadeau <ja...@apache.org>
Date: 2016-01-02T22:55:21Z
DRILL-4238: Add a custom RPC interface on the Control channel for extensible communication between bits.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4238: Add a custom RPC interface on the ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/313
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4238: Add a custom RPC interface on the ...
Posted by StevenMPhillips <gi...@git.apache.org>.
Github user StevenMPhillips commented on the pull request:
https://github.com/apache/drill/pull/313#issuecomment-170433313
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4238: Add a custom RPC interface on the ...
Posted by jacques-n <gi...@git.apache.org>.
Github user jacques-n commented on the pull request:
https://github.com/apache/drill/pull/313#issuecomment-168447779
@StevenMPhillips , let me know your thoughts.
To others interested, this doesn't modify any existing code paths so has no impact on existing workloads.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---