You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by GitBox <gi...@apache.org> on 2020/02/19 23:37:43 UTC
[GitHub] [submarine] cchung100m opened a new pull request #188:
SUBMARINE-281. Remove chinese characters
cchung100m opened a new pull request #188: SUBMARINE-281. Remove chinese characters
URL: https://github.com/apache/submarine/pull/188
### What is this PR for?
Remove Chinese characters from source code
### What type of PR is it?
[Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-281
### How should this be tested?
https://travis-ci.com/cchung100m/submarine/builds/149643127
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] asfgit closed pull request #188: SUBMARINE-281. Remove
Chinese characters
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #188: SUBMARINE-281. Remove Chinese characters
URL: https://github.com/apache/submarine/pull/188
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] cchung100m commented on issue #188: SUBMARINE-281.
Remove Chinese characters
Posted by GitBox <gi...@apache.org>.
cchung100m commented on issue #188: SUBMARINE-281. Remove Chinese characters
URL: https://github.com/apache/submarine/pull/188#issuecomment-588613264
Hi @liuxunorg
Thanks for review.
Hi @jiwq
Sure, any suggestions/guidelines for more description info are welcome. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on issue #188: SUBMARINE-281.
Remove Chinese characters
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on issue #188: SUBMARINE-281. Remove Chinese characters
URL: https://github.com/apache/submarine/pull/188#issuecomment-588579131
@cchung100m Thank you for contribution.
Will merge if no more comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org