You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "wanghenshui (via GitHub)" <gi...@apache.org> on 2023/05/04 03:50:25 UTC

[GitHub] [incubator-kvrocks] wanghenshui opened a new issue, #1417: feat: rate limiter support

wanghenshui opened a new issue, #1417:
URL: https://github.com/apache/incubator-kvrocks/issues/1417

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
   
   
   ### Motivation
   
   
   https://rocksdb.org/blog/2017/12/18/17-auto-tuned-rate-limiter.html
   
   ### Solution
   
   ```c++
   rocksdb::NewGenericRateLimiter(
           rate_limiter_bandwidth(),
           rate_limiter_refill_period_us(),
           rate_limiter_fairness(),
           rocksdb::RateLimiter::Mode::kWritesOnly,
           rate_limiter_auto_tuned()
         );
   ```
   
   
   ### Are you willing to submit a PR?
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] mapleFU commented on issue #1417: feat: rate limiter support auto tune

Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on issue #1417:
URL: https://github.com/apache/incubator-kvrocks/issues/1417#issuecomment-1534085397

   Seems that it can benefits I/O scheduling rather than using `kIORateLimitMaxMb` as fixed io limits? Should we default using that or just as a config?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on issue #1417: feat: rate limiter support auto tune

Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #1417:
URL: https://github.com/apache/incubator-kvrocks/issues/1417#issuecomment-1534124499

   > Seems that it can benefits I/O scheduling rather than using `kIORateLimitMaxMb` as fixed io limits? Should we default using that or just as a config?
   
   I think it'd be better to make this as default. How do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk closed issue #1417: Add support of RocksDB auto-tune rate limiter for the background IO

Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk closed issue #1417: Add support of RocksDB auto-tune rate limiter for the background IO
URL: https://github.com/apache/incubator-kvrocks/issues/1417


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] mapleFU commented on issue #1417: feat: rate limiter support auto tune

Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on issue #1417:
URL: https://github.com/apache/incubator-kvrocks/issues/1417#issuecomment-1534127895

   I guess we can, but we'd better testing it first. @xiaobiaozhao would you like to take a look or do some testing if auto tune rate limiter is supportted?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] xiaobiaozhao commented on issue #1417: Add support of RocksDB auto-tune rate limiter for the background IO

Posted by "xiaobiaozhao (via GitHub)" <gi...@apache.org>.
xiaobiaozhao commented on issue #1417:
URL: https://github.com/apache/incubator-kvrocks/issues/1417#issuecomment-1534177467

   1. This parameter looks very good, can promote the whole DB performance college
   2. I can test the parameters of performance improvement this weekend


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on issue #1417: feat: rate limiter support auto tune

Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #1417:
URL: https://github.com/apache/incubator-kvrocks/issues/1417#issuecomment-1534065563

   Hi @wanghenshui 
   
   Thanks for your proposal, would you like to take this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] wanghenshui commented on issue #1417: feat: rate limiter support auto tune

Posted by "wanghenshui (via GitHub)" <gi...@apache.org>.
wanghenshui commented on issue #1417:
URL: https://github.com/apache/incubator-kvrocks/issues/1417#issuecomment-1534091841

   > Hi @wanghenshui
   > 
   > Thanks for your proposal, would you like to take this?
   
   ok


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org