[GitHub] [storm] Ethanlm commented on a change in pull request #3213: [STORM-3588] add GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource in grading topologies

[GitBox <gi...@apache.org>]

Ethanlm commented on a change in pull request #3213: [STORM-3588] add GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource in grading topologies
URL: https://github.com/apache/storm/pull/3213#discussion_r386453674
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java
 ##########
 @@ -256,7 +256,8 @@ private void scheduleTopology(TopologyDetails td, Cluster cluster, final User to
         if (forTest) {
             return this.evictedTopologies;
         } else {
-            throw new Exception("Topology eviction check is only provided for test purposes");
+            throw new UnsupportedOperationException(
 
 Review comment:
   `UnsupportedOperationException` is a runtime exception. `throws Exception` is not needed in the signature. So is in the unit tests like testDefaultSchedulingPriorityStrategyNotEvicting

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services