You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/08/01 12:03:23 UTC

[GitHub] [maven] rfscholte commented on a change in pull request #518: [MNG-7199] MAVENHOME_CONFIG var in mvnlauncher script improperly hand…

rfscholte commented on a change in pull request #518:
URL: https://github.com/apache/maven/pull/518#discussion_r680501013



##########
File path: apache-maven/src/assembly/shared/run
##########
@@ -14,6 +14,7 @@ exec "$JAVACMD" \
   $MAVEN_OPTS \
   $MAVEN_DEBUG_OPTS \
   -classpath "${LAUNCHER_JAR}" \
-  $MAVENHOME_CONFIG \
+  "-Dclassworlds.conf=$CLASSWOLRDS_CONF" \

Review comment:
       typo in `CLASSWOLRDS`, but why use/introduce a variable if we can say `-Dclassworlds.conf=${MAVEN_HOME}/bin/m2.conf` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org