You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Ben Laurie <be...@algroup.co.uk> on 2000/06/13 23:43:14 UTC
[PATCH] V3 of command handler patch
This one is even less complete - but more perfect, IMO - than previous
attempts. Note that I didn't use Dean's typeof() trick, coz it doesn't
quite do what I want. Nor did I use the c9x syntax for unions, coz my
compiler won't compile it. Nor have I done anything but the most
superficial fixes for the numerous const violations (i.e., they mostly
ain't fixed).
And if anyone suggests a new way of doing this, they die. Unless its
better, of course. :-)
Do I commit? BTW, I'm out all day tomorrow, so expect a delay.
Cheers,
Ben.
--
http://www.apache-ssl.org/ben.html
Coming to ApacheCon Europe 2000? http://apachecon.com/
Re: [PATCH] V3 of command handler patch
Posted by David Reid <dr...@jetnet.co.uk>.
Now now boys, play nice :-)
----- Original Message -----
From: "Greg Stein" <gs...@lyra.org>
To: <ne...@apache.org>
Sent: Tuesday, June 13, 2000 11:53 PM
Subject: Re: [PATCH] V3 of command handler patch
> On Tue, Jun 13, 2000 at 03:37:53PM -0700, rbb@covalent.net wrote:
> >...
> > I'll work on the converter this week. This will give me a chance to
test
> > my burgeoning PERL skills (which is always a plus). :-)
>
> A plus? hehe... I have an alternative for you that I consider a *real*
> plus... :-)
>
> Cheers,
> -g
>
> --
> Greg Stein, http://www.lyra.org/
>
Re: [PATCH] V3 of command handler patch
Posted by rb...@covalent.net.
> > I'll work on the converter this week. This will give me a chance to test
> > my burgeoning PERL skills (which is always a plus). :-)
>
> A plus? hehe... I have an alternative for you that I consider a *real*
> plus... :-)
Gee... let me guess, is that Python. I language at a time okay, Greg.
Ryan
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------
Re: [PATCH] V3 of command handler patch
Posted by Greg Stein <gs...@lyra.org>.
On Tue, Jun 13, 2000 at 03:37:53PM -0700, rbb@covalent.net wrote:
>...
> I'll work on the converter this week. This will give me a chance to test
> my burgeoning PERL skills (which is always a plus). :-)
A plus? hehe... I have an alternative for you that I consider a *real*
plus... :-)
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
Re: [PATCH] V3 of command handler patch
Posted by rb...@covalent.net.
> > +0. I love the idea, but I am grimacing at the amount the command table
> > has to change. I wish I could come up with a solution that has less of an
> > impact on module writers.
>
> One of the neat things about this patch is that module writers don't need to
> change *anything* ... unless they use the "maintainer mode", too.
>
> These changes are only visible to maintainers.
Okay, I see what I missed. I would like to move the beginning and
trailing '{' and '}' out of the AP_INIT_(RAW_ARGS | AP_TAKE1) macros,
because I think this makes things a little bit nicer, but I won't fight
for that. I am +1 now that my eyes have been opened.
> > BTW, I am +1 with the conversion script, because the warnings are worth
> > the change, I just want to make it an easy move for module authors.
>
> This would be quite nice ... even better. I like the change with or without
> the converter. Feel free :-)
I'll work on the converter this week. This will give me a chance to test
my burgeoning PERL skills (which is always a plus). :-)
Ryan
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------
Re: [PATCH] V3 of command handler patch
Posted by Greg Stein <gs...@lyra.org>.
On Tue, Jun 13, 2000 at 03:08:51PM -0700, rbb@covalent.net wrote:
> > > This one is even less complete - but more perfect, IMO - than previous
> > > attempts. Note that I didn't use Dean's typeof() trick, coz it doesn't
> > > quite do what I want. Nor did I use the c9x syntax for unions, coz my
> > > compiler won't compile it. Nor have I done anything but the most
> > > superficial fixes for the numerous const violations (i.e., they mostly
> > > ain't fixed).
> > >
> > > And if anyone suggests a new way of doing this, they die. Unless its
> > > better, of course. :-)
> > >
> > > Do I commit? BTW, I'm out all day tomorrow, so expect a delay.
> >
> > +1
>
> +0. I love the idea, but I am grimacing at the amount the command table
> has to change. I wish I could come up with a solution that has less of an
> impact on module writers.
One of the neat things about this patch is that module writers don't need to
change *anything* ... unless they use the "maintainer mode", too.
These changes are only visible to maintainers.
Sure, it is going to bite us, until we get stuff converted, but it
(strictly) isn't going to affect module writers too badly.
>...
> BTW, I am +1 with the conversion script, because the warnings are worth
> the change, I just want to make it an easy move for module authors.
This would be quite nice ... even better. I like the change with or without
the converter. Feel free :-)
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
Re: [PATCH] V3 of command handler patch
Posted by rb...@covalent.net.
> > This one is even less complete - but more perfect, IMO - than previous
> > attempts. Note that I didn't use Dean's typeof() trick, coz it doesn't
> > quite do what I want. Nor did I use the c9x syntax for unions, coz my
> > compiler won't compile it. Nor have I done anything but the most
> > superficial fixes for the numerous const violations (i.e., they mostly
> > ain't fixed).
> >
> > And if anyone suggests a new way of doing this, they die. Unless its
> > better, of course. :-)
> >
> > Do I commit? BTW, I'm out all day tomorrow, so expect a delay.
>
> +1
+0. I love the idea, but I am grimacing at the amount the command table
has to change. I wish I could come up with a solution that has less of an
impact on module writers. Is there a chance we could commit this with a
shell or perl script that makes the modifications for the module
writer? We don't need to do it 100% correctly, but it would be great if
we could come very close. Yes, these changes are minimal, but imagine
somebody with a number of modules they need to port. These changes add up
quickly. I will volunteer to create the converter script. :-)
BTW, I am +1 with the conversion script, because the warnings are worth
the change, I just want to make it an easy move for module authors.
Ryan
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------
Re: [PATCH] V3 of command handler patch
Posted by Greg Stein <gs...@lyra.org>.
On Tue, Jun 13, 2000 at 10:43:14PM +0100, Ben Laurie wrote:
> This one is even less complete - but more perfect, IMO - than previous
> attempts. Note that I didn't use Dean's typeof() trick, coz it doesn't
> quite do what I want. Nor did I use the c9x syntax for unions, coz my
> compiler won't compile it. Nor have I done anything but the most
> superficial fixes for the numerous const violations (i.e., they mostly
> ain't fixed).
>
> And if anyone suggests a new way of doing this, they die. Unless its
> better, of course. :-)
>
> Do I commit? BTW, I'm out all day tomorrow, so expect a delay.
+1
--
Greg Stein, http://www.lyra.org/