[GitHub] [calcite] yanlin-Lynn commented on a change in pull request #1516: [CALCITE-3423] Support using CAST operation and BOOLEAN type value in table macro

[GitBox <gi...@apache.org>]

yanlin-Lynn commented on a change in pull request #1516: [CALCITE-3423] Support using CAST operation and BOOLEAN type value in table macro
URL: https://github.com/apache/calcite/pull/1516#discussion_r342926596
 
 

 ##########
 File path: core/src/test/java/org/apache/calcite/test/TableFunctionTest.java
 ##########
 @@ -359,16 +359,10 @@ private Connection getConnectionWithMultiplyFunction() throws SQLException {
   }
 
   @Test public void testUserDefinedTableFunction4() {
-    final String q = "select *\n"
+    final String q = "select \"c1\"\n"
 
 Review comment:
   Because now type coercion is supported,  running this test will get a valid result.
   So I change this test to make it the same like `testUserDefinedTableFunction3`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services