[GitHub] [lucene] iverase commented on pull request #107: LUCENE-9047: Move the Directory APIs to be little endian (take 2)

[GitBox <gi...@apache.org>]

iverase commented on pull request #107:
URL: https://github.com/apache/lucene/pull/107#issuecomment-828513235


   I will set the PR ready to review as feedback has been positive so far. I want to stress that the most interesting part is how to deal with reading `segment.gen`. This file does not belong to a codec so we open it blind without knowing the endianness. Therefore the approach I have taken is to write that file always big endian as we are doing until now.
   
   In addition as this files have a codec header / footer, then all headers / footers will be written using BE order. 
   
   Maybe @rmuir and @mikemccand have an opinion here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org