You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "EnxDev (via GitHub)" <gi...@apache.org> on 2026/05/26 11:58:06 UTC

[PR] feat(extensions): chatbot mount point, singleton resolver, and admin settings (SIP P1+P2) [superset]

EnxDev opened a new pull request, #40433:
URL: https://github.com/apache/superset/pull/40433

   ### SUMMARY
   
   Implements Phase 1 and Phase 2 of the chatbot extension architecture defined in the chatbot SIP.
   
   **P1 — Mount point & registration**
   - Extends `ViewContributions` manifest schema with an `app` scope so `superset.chatbot` can be declared in `extension.json`
   - Adds `CHATBOT_LOCATION = 'superset.chatbot'` constant and `AppViewLocations` structure in `src/views/contributions.ts`
   - Adds host-internal `getViewProvider(location, id)` and `getRegisteredViewIds(location)` to `src/core/views` — not exposed on the public `@apache-superset/core` API, preserving the `getViews` descriptor-only boundary
   - Adds `subscribeToLocation` for reactive re-resolution when the registry changes
   - Adds `icon?: string` field to the `View` descriptor (static, set at `registerView()` time) and a `ChatbotView` type alias for extension authors
   - Adds `src/core/chatbot/getActiveChatbot` — first-to-register fallback policy
   - Adds `ChatbotMount` component: fixed bottom-right, `zIndexPopupBase + 2`, host-owned `ErrorBoundary`, reactive via `subscribeToLocation`
   - Mounts `<ChatbotMount />` as a sibling of `<Switch>` inside `ExtensionsStartup` so the bubble persists across route changes
   - Host-level `unhandledrejection` isolation in `ExtensionsStartup` covers extension async failures
   
   **P2 — Admin & singleton selection**
   - Adds `ExtensionSettings` (singleton row) and `ExtensionEnabled` (per-extension flag) SQLAlchemy models
   - Adds Alembic migration `b2c3d4e5f6a7`
   - Adds `GET /api/v1/extensions/settings` and `PUT /api/v1/extensions/settings` endpoints
   - `ChatbotMount` fetches `active_chatbot_id` on mount and passes it to `getActiveChatbot`
   - `ExtensionsList` shows a "Default chatbot" `Select` picker when more than one chatbot is registered
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   N/A — infrastructure only, no visible UI change until a chatbot extension is installed.
   
   ### TESTING INSTRUCTIONS
   
   1. Install a chatbot extension that calls `views.registerView({ id: 'my.chatbot', name: 'My Chatbot' }, 'superset.chatbot', () => <MyBot />)`
   2. Verify the bubble appears fixed at the bottom-right corner across all routes
   3. Install two chatbot extensions; verify only one renders at a time
   4. Go to Extensions → set "Default chatbot" → verify the correct one renders
   5. Disable a chatbot via the toggle; verify it stops rendering
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [x] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [x] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [x] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(extensions): adds chatbot P1-P2 [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #40433:
URL: https://github.com/apache/superset/pull/40433#discussion_r3303530099


##########
superset/extensions/settings.py:
##########
@@ -0,0 +1,55 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""Admin settings persistence for extensions (active chatbot, enable/disable)."""
+
+from typing import Any
+
+from superset import db
+from superset.models.core import ExtensionEnabled, ExtensionSettings
+
+_SETTINGS_ROW_ID = 1
+
+
+def get_extension_settings() -> dict[str, Any]:
+    row = db.session.get(ExtensionSettings, _SETTINGS_ROW_ID)
+    enabled_rows = db.session.query(ExtensionEnabled).all()
+    return {
+        "active_chatbot_id": row.active_chatbot_id if row else None,
+        "enabled": {r.extension_id: r.enabled for r in enabled_rows},
+    }
+
+
+def update_extension_settings(body: dict[str, Any]) -> dict[str, Any]:
+    row = db.session.get(ExtensionSettings, _SETTINGS_ROW_ID)
+    if row is None:
+        row = ExtensionSettings(id=_SETTINGS_ROW_ID)
+        db.session.add(row)
+
+    if "active_chatbot_id" in body:
+        row.active_chatbot_id = body["active_chatbot_id"] or None

Review Comment:
   **Suggestion:** `active_chatbot_id` is assigned directly from request data without type checking; non-string JSON values (object/array) will fail at commit time against a string column and surface as a 500. Validate/cast this field to a string-or-null before persisting. [type error]
   
   <details>
   <summary><b>Severity Level:</b> Major ⚠️</summary>
   
   ```mdx
   - ❌ Non-string chatbot id payload crashes settings endpoint.
   - ⚠️ Chatbot settings update unreliable for mis-typed clients.
   ```
   </details>
   <details>
   <summary><b>Steps of Reproduction ✅ </b></summary>
   
   ```mdx
   1. Issue a malformed request to the settings endpoint `PUT /api/v1/extensions/settings`
   (handled by `ExtensionsRestApi.put_settings` in `superset/extensions/api.py:71-56`) with a
   non-string `active_chatbot_id`, e.g. JSON `{"active_chatbot_id": {"id": "chatbot.one"}}`.
   
   2. `put_settings` deserializes the JSON into `body={"active_chatbot_id": {"id":
   "chatbot.one"}}` and calls `update_extension_settings(body)` in
   `superset/extensions/settings.py:37-55`.
   
   3. In `update_extension_settings`, the block at `settings.py:43-44` executes because
   `"active_chatbot_id" in body` is true, and assigns `row.active_chatbot_id =
   body["active_chatbot_id"] or None`, so `row.active_chatbot_id` becomes a Python `dict`
   instead of a string.
   
   4. When `db.session.commit()` runs at `settings.py:54`, SQLAlchemy attempts to persist
   that dict into the `ExtensionSettings.active_chatbot_id` column declared as `String(250)`
   in `superset/models/core.py:12-18`, which can cause a database adapter error and surface
   as a 500 response on `/api/v1/extensions/settings` instead of rejecting the bad input up
   front.
   ```
   </details>
   
   [Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=4b5bb1fdc2984e77b706c32bd35c0d61&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=4b5bb1fdc2984e77b706c32bd35c0d61&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   
   *(Use Cmd/Ctrl + Click for best experience)*
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset/extensions/settings.py
   **Line:** 43:44
   **Comment:**
   	*Type Error: `active_chatbot_id` is assigned directly from request data without type checking; non-string JSON values (object/array) will fail at commit time against a string column and surface as a 500. Validate/cast this field to a string-or-null before persisting.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40433&comment_hash=e4e25a90cd9a63a0cd2fa2e5b696d21e0ec9e0b883c32d95b80752d670687ac2&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40433&comment_hash=e4e25a90cd9a63a0cd2fa2e5b696d21e0ec9e0b883c32d95b80752d670687ac2&reaction=dislike'>👎</a>



##########
superset/extensions/settings.py:
##########
@@ -0,0 +1,55 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""Admin settings persistence for extensions (active chatbot, enable/disable)."""
+
+from typing import Any
+
+from superset import db
+from superset.models.core import ExtensionEnabled, ExtensionSettings
+
+_SETTINGS_ROW_ID = 1
+
+
+def get_extension_settings() -> dict[str, Any]:
+    row = db.session.get(ExtensionSettings, _SETTINGS_ROW_ID)
+    enabled_rows = db.session.query(ExtensionEnabled).all()
+    return {
+        "active_chatbot_id": row.active_chatbot_id if row else None,
+        "enabled": {r.extension_id: r.enabled for r in enabled_rows},
+    }
+
+
+def update_extension_settings(body: dict[str, Any]) -> dict[str, Any]:
+    row = db.session.get(ExtensionSettings, _SETTINGS_ROW_ID)
+    if row is None:
+        row = ExtensionSettings(id=_SETTINGS_ROW_ID)
+        db.session.add(row)
+
+    if "active_chatbot_id" in body:
+        row.active_chatbot_id = body["active_chatbot_id"] or None
+
+    if "enabled" in body:
+        for extension_id, enabled in body["enabled"].items():
+            flag = db.session.get(ExtensionEnabled, extension_id)
+            if flag is None:
+                flag = ExtensionEnabled(extension_id=extension_id)
+                db.session.add(flag)
+            flag.enabled = bool(enabled)

Review Comment:
   **Suggestion:** Coercing `enabled` with `bool(enabled)` misinterprets non-boolean values (for example `"false"` becomes `True`), which can silently flip the stored setting to the wrong value. Require actual boolean input and reject or strictly parse other types. [incorrect condition logic]
   
   <details>
   <summary><b>Severity Level:</b> Major ⚠️</summary>
   
   ```mdx
   - ❌ Wrong enable flag stored for string boolean inputs.
   - ⚠️ Admin cannot reliably disable extensions via custom clients.
   ```
   </details>
   <details>
   <summary><b>Steps of Reproduction ✅ </b></summary>
   
   ```mdx
   1. Call the settings update endpoint `PUT /api/v1/extensions/settings` handled by
   `ExtensionsRestApi.put_settings` in `superset/extensions/api.py:71-56`, but send a payload
   where `enabled` values are strings instead of booleans, e.g. `{"enabled":
   {"example.extension": "false"}}`.
   
   2. `put_settings` parses the JSON into `body={"enabled": {"example.extension": "false"}}`
   and invokes `update_extension_settings(body)` in `superset/extensions/settings.py:37-55`.
   
   3. In `update_extension_settings`, the loop at `settings.py:46-52` iterates `for
   extension_id, enabled in body["enabled"].items():` and eventually executes `flag.enabled =
   bool(enabled)` at line 52, where `enabled` is the string `"false"`.
   
   4. Python truthiness rules treat any non-empty string as `True`, so `"false"` becomes
   `True` and is stored into the `ExtensionEnabled.enabled` Boolean column
   (`superset/models/core.py:20-25`), causing the extension to remain enabled even though the
   client attempted to disable it.
   ```
   </details>
   
   [Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=b3abdc21aef74c7f9d555b83b270b175&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=b3abdc21aef74c7f9d555b83b270b175&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   
   *(Use Cmd/Ctrl + Click for best experience)*
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset/extensions/settings.py
   **Line:** 52:52
   **Comment:**
   	*Incorrect Condition Logic: Coercing `enabled` with `bool(enabled)` misinterprets non-boolean values (for example `"false"` becomes `True`), which can silently flip the stored setting to the wrong value. Require actual boolean input and reject or strictly parse other types.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40433&comment_hash=f897bafe3f95e884fc2d466c78dffbd62fb4ea74d4ef5018d65c954e7df8d3ec&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40433&comment_hash=f897bafe3f95e884fc2d466c78dffbd62fb4ea74d4ef5018d65c954e7df8d3ec&reaction=dislike'>👎</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(extensions): adds chatbot P1-P2 [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #40433:
URL: https://github.com/apache/superset/pull/40433#discussion_r3303520759


##########
superset-frontend/src/extensions/ExtensionsList.tsx:
##########
@@ -50,6 +61,45 @@ const ExtensionsList: FunctionComponent<ExtensionsListProps> = ({
     addDangerToast,
   );
 
+  const [settings, setSettings] = useState<ExtensionSettings>({
+    active_chatbot_id: null,
+    enabled: {},
+  });
+
+  useEffect(() => {
+    SupersetClient.get({ endpoint: '/api/v1/extensions/settings' })
+      .then(({ json }) => setSettings(json.result))
+      .catch(() => addDangerToast(t('Failed to load extension settings.')));
+  }, [addDangerToast]);
+
+  const saveSettings = useCallback(
+    (patch: Partial<ExtensionSettings>) => {
+      const next = { ...settings, ...patch };
+      SupersetClient.put({
+        endpoint: '/api/v1/extensions/settings',
+        jsonPayload: next,
+      })
+        .then(({ json }) => {
+          setSettings(json.result);
+          addSuccessToast(t('Settings saved.'));
+        })
+        .catch(() => addDangerToast(t('Failed to save extension settings.')));
+    },
+    [settings, addDangerToast, addSuccessToast],
+  );
+
+  const toggleEnabled = useCallback(
+    (extensionId: string, enabled: boolean) => {
+      saveSettings({ enabled: { ...settings.enabled, [extensionId]: enabled } });
+    },
+    [settings, saveSettings],
+  );
+
+  const chatbotExtensions = useMemo(() => {
+    const chatbotIds = new Set(getRegisteredViewIds(CHATBOT_LOCATION));
+    return resourceCollection.filter(ext => chatbotIds.has(ext.id));
+  }, [resourceCollection]);

Review Comment:
   **🟠 Architect Review — HIGH**
   
   The "Default chatbot" options are derived from `getRegisteredViewIds(CHATBOT_LOCATION)` inside a `useMemo` that only depends on `resourceCollection`, so because chatbot views register asynchronously during `initializeExtensions`, the picker can miss chatbots that register after the first render and never update in that session.
   
   **Suggestion:** Recompute `chatbotExtensions` reactively when the chatbot location registry changes (e.g., via `subscribeToLocation`) or derive chatbot-capable extensions from backend metadata instead of a one-time registry snapshot so the picker always reflects the currently registered chatbots.
   
   
   [Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=a2d972d0a0204cf3ba81cb75ff952fd1&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=a2d972d0a0204cf3ba81cb75ff952fd1&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   
   *(Use Cmd/Ctrl + Click for best experience)*
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is an **Architect / Logical Review** comment left during a code review. These reviews are first-class, important findings — not optional suggestions. Do NOT dismiss this as a 'big architectural change' just because the title says architect review; most of these can be resolved with a small, localized fix once the intent is understood.
   
   **Path:** superset-frontend/src/extensions/ExtensionsList.tsx
   **Line:** 98:101
   **Comment:**
   	*HIGH: The "Default chatbot" options are derived from `getRegisteredViewIds(CHATBOT_LOCATION)` inside a `useMemo` that only depends on `resourceCollection`, so because chatbot views register asynchronously during `initializeExtensions`, the picker can miss chatbots that register after the first render and never update in that session.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   If a suggested approach is provided above, use it as the authoritative instruction. If no explicit code suggestion is given, you MUST still draft and apply your own minimal, localized fix — do not punt back with 'no suggestion provided, review manually'. Keep the change as small as possible: add a guard clause, gate on a loading state, reorder an await, wrap in a conditional, etc. Do not refactor surrounding code or expand scope beyond the finding.
   Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>



##########
superset/extensions/settings.py:
##########
@@ -0,0 +1,55 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""Admin settings persistence for extensions (active chatbot, enable/disable)."""
+
+from typing import Any
+
+from superset import db
+from superset.models.core import ExtensionEnabled, ExtensionSettings
+
+_SETTINGS_ROW_ID = 1
+
+
+def get_extension_settings() -> dict[str, Any]:
+    row = db.session.get(ExtensionSettings, _SETTINGS_ROW_ID)
+    enabled_rows = db.session.query(ExtensionEnabled).all()
+    return {
+        "active_chatbot_id": row.active_chatbot_id if row else None,
+        "enabled": {r.extension_id: r.enabled for r in enabled_rows},
+    }
+
+
+def update_extension_settings(body: dict[str, Any]) -> dict[str, Any]:
+    row = db.session.get(ExtensionSettings, _SETTINGS_ROW_ID)
+    if row is None:
+        row = ExtensionSettings(id=_SETTINGS_ROW_ID)
+        db.session.add(row)
+
+    if "active_chatbot_id" in body:
+        row.active_chatbot_id = body["active_chatbot_id"] or None
+
+    if "enabled" in body:
+        for extension_id, enabled in body["enabled"].items():
+            flag = db.session.get(ExtensionEnabled, extension_id)
+            if flag is None:
+                flag = ExtensionEnabled(extension_id=extension_id)
+                db.session.add(flag)
+            flag.enabled = bool(enabled)

Review Comment:
   **🟠 Architect Review — HIGH**
   
   The new per-extension `enabled` flag is persisted in `extension_settings`/`extension_enabled` but never consulted when listing or serving extensions, so disabling an extension in admin settings does not actually prevent it from being loaded or its assets from being served.
   
   **Suggestion:** Wire the `enabled` flags into the runtime: filter out disabled extensions when building `/api/v1/extensions/` (and when resolving `/api/v1/extensions/<publisher>/<name>` and the asset endpoint), and hook into `ExtensionsLoader`/`deactivateExtension` so disabled extensions are not initialized or remain active after a settings change.
   
   
   [Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=071f1fb7e5bc442ca83ec4cf3b969e19&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=071f1fb7e5bc442ca83ec4cf3b969e19&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   
   *(Use Cmd/Ctrl + Click for best experience)*
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is an **Architect / Logical Review** comment left during a code review. These reviews are first-class, important findings — not optional suggestions. Do NOT dismiss this as a 'big architectural change' just because the title says architect review; most of these can be resolved with a small, localized fix once the intent is understood.
   
   **Path:** superset/extensions/settings.py
   **Line:** 46:52
   **Comment:**
   	*HIGH: The new per-extension `enabled` flag is persisted in `extension_settings`/`extension_enabled` but never consulted when listing or serving extensions, so disabling an extension in admin settings does not actually prevent it from being loaded or its assets from being served.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   If a suggested approach is provided above, use it as the authoritative instruction. If no explicit code suggestion is given, you MUST still draft and apply your own minimal, localized fix — do not punt back with 'no suggestion provided, review manually'. Keep the change as small as possible: add a guard clause, gate on a loading state, reorder an await, wrap in a conditional, etc. Do not refactor surrounding code or expand scope beyond the finding.
   Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(extensions): adds chatbot P1-P2 [superset]

Posted by "EnxDev (via GitHub)" <gi...@apache.org>.
EnxDev closed pull request #40433: feat(extensions): adds chatbot P1-P2
URL: https://github.com/apache/superset/pull/40433


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(extensions): adds chatbot P1-P2 [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #40433:
URL: https://github.com/apache/superset/pull/40433#discussion_r3303531236


##########
superset-frontend/src/extensions/ExtensionsList.tsx:
##########
@@ -50,6 +61,45 @@ const ExtensionsList: FunctionComponent<ExtensionsListProps> = ({
     addDangerToast,
   );
 
+  const [settings, setSettings] = useState<ExtensionSettings>({
+    active_chatbot_id: null,
+    enabled: {},
+  });
+
+  useEffect(() => {
+    SupersetClient.get({ endpoint: '/api/v1/extensions/settings' })
+      .then(({ json }) => setSettings(json.result))
+      .catch(() => addDangerToast(t('Failed to load extension settings.')));
+  }, [addDangerToast]);
+
+  const saveSettings = useCallback(
+    (patch: Partial<ExtensionSettings>) => {
+      const next = { ...settings, ...patch };
+      SupersetClient.put({
+        endpoint: '/api/v1/extensions/settings',
+        jsonPayload: next,

Review Comment:
   **Suggestion:** Saving always sends a full object built from a captured `settings` snapshot, so overlapping saves from different controls can overwrite each other (for example, a later toggle request can revert a recently selected default chatbot). Avoid closure-stale full-payload writes by basing updates on latest state and/or sending only the changed patch to the backend. [race condition]
   
   <details>
   <summary><b>Severity Level:</b> Major ⚠️</summary>
   
   ```mdx
   - ❌ Rapid edits can silently revert saved chatbot selection.
   - ⚠️ Enabled flags may not match latest admin intention.
   ```
   </details>
   <details>
   <summary><b>Steps of Reproduction ✅ </b></summary>
   
   ```mdx
   1. On the `/extensions/list/` admin page, `ExtensionsList` loads the current settings into
   local state via a GET to `/api/v1/extensions/settings`
   (superset-frontend/src/extensions/ExtensionsList.tsx:64-73) and defines `saveSettings`
   using the then-current `settings` snapshot (lines 75-89).
   
   2. The admin changes the default chatbot using the "Default chatbot" `<Select>`
   (superset-frontend/src/extensions/ExtensionsList.tsx:145-163); its `onChange` calls
   `saveSettings({ active_chatbot_id: (value as string) ?? null })` (lines 153-159). Inside
   `saveSettings`, `const next = { ...settings, ...patch };` (line 77) merges this patch into
   the captured `settings` and sends a PUT to `/api/v1/extensions/settings` with the full
   `next` object (lines 78-80).
   
   3. Before the first PUT resolves and updates local state via `setSettings(json.result)`
   (superset-frontend/src/extensions/ExtensionsList.tsx:83), the admin toggles an extension's
   "Enabled" switch. The `toggleEnabled` handler (lines 91-95) calls `saveSettings({ enabled:
   { ...settings.enabled, [extensionId]: enabled } })`, but this `saveSettings` closure is
   still using the same stale `settings` snapshot from before the chatbot change, so `next`
   is recomputed from the original settings (with the old `active_chatbot_id`) plus the
   updated `enabled` map.
   
   4. Both PUTs are handled by `ExtensionsRestApi.put_settings`
   (superset/superset/extensions/api.py:190-215), which delegates to
   `update_extension_settings` (superset/superset/extensions/settings.py:37-54). Since
   `update_extension_settings` applies both `active_chatbot_id` and `enabled` whenever those
   keys are present in the body, the second request—built from the stale snapshot—reapplies
   the old `active_chatbot_id` while updating `enabled`, effectively overwriting the fresh
   chatbot selection from the first request and leaving backend settings that do not reflect
   the admin's most recent combination of changes.
   ```
   </details>
   
   [Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=8a6b26ac51394ff88d514e1f399504c4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=8a6b26ac51394ff88d514e1f399504c4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   
   *(Use Cmd/Ctrl + Click for best experience)*
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset-frontend/src/extensions/ExtensionsList.tsx
   **Line:** 77:80
   **Comment:**
   	*Race Condition: Saving always sends a full object built from a captured `settings` snapshot, so overlapping saves from different controls can overwrite each other (for example, a later toggle request can revert a recently selected default chatbot). Avoid closure-stale full-payload writes by basing updates on latest state and/or sending only the changed patch to the backend.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40433&comment_hash=9d8709b4644a601308fff75747afb474fd549b65da6052a7bfcd07520572cd52&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40433&comment_hash=9d8709b4644a601308fff75747afb474fd549b65da6052a7bfcd07520572cd52&reaction=dislike'>👎</a>



##########
superset-frontend/src/extensions/ExtensionsList.tsx:
##########
@@ -58,15 +108,34 @@ const ExtensionsList: FunctionComponent<ExtensionsListProps> = ({
         size: 'lg',
         id: 'name',
         Cell: ({
-          row: {
-            original: { name },
-          },
+          row: { original: { name } },
         }: any) => name,
       },
+      {
+        Header: t('Enabled'),
+        accessor: 'enabled',
+        size: 'sm',
+        id: 'enabled',
+        Cell: ({
+          row: { original: { id, enabled } },
+        }: any) => (
+          <Switch
+            data-test="toggle-enabled"
+            checked={settings.enabled[id] ?? enabled}
+            onClick={(checked: boolean) => toggleEnabled(id, checked)}
+            size="small"
+          />
+        ),

Review Comment:
   **Suggestion:** The switch fallback uses `enabled` from the extensions list payload, but `/api/v1/extensions/` does not provide an `enabled` field (it only returns extension metadata), so untouched rows resolve to `undefined` and render with an incorrect checked state. Use an explicit default (for example `true`) or source enabled state solely from settings with a deterministic fallback. [api mismatch]
   
   <details>
   <summary><b>Severity Level:</b> Major ⚠️</summary>
   
   ```mdx
   - ❌ Extensions admin switches show incorrect enabled state initially.
   - ⚠️ Future enforcement of flags may start from wrong values.
   ```
   </details>
   <details>
   <summary><b>Steps of Reproduction ✅ </b></summary>
   
   ```mdx
   1. As an admin with `FeatureFlag.EnableExtensions` enabled, navigate to
   `/extensions/list/`, which routes to the lazy `Extensions` component
   (superset-frontend/src/views/routes.tsx:170-175) and mounts `ExtensionsList`
   (superset-frontend/src/extensions/ExtensionsList.tsx:50-53).
   
   2. `ExtensionsList` uses `useListViewResource<Extension>('extensions', ...)`
   (superset-frontend/src/extensions/ExtensionsList.tsx:54-62). The hook's `fetchData` issues
   `GET /api/v1/extensions/?q=...` for the `extensions` resource
   (superset-frontend/src/views/CRUD/hooks.ts:152-196).
   
   3. The backend handler `ExtensionsRestApi.get_list`
   (superset/superset/extensions/api.py:74-120) builds each entry via `build_extension_data`
   (superset/superset/extensions/utils.py:233-255), which returns objects containing `id`,
   `name`, `version`, `description`, `dependencies`, and optional frontend fields, but no
   `enabled` property.
   
   4. In `ExtensionsList` the "Enabled" column renders a `<Switch>` whose `checked` value is
   `settings.enabled[id] ?? enabled`
   (superset-frontend/src/extensions/ExtensionsList.tsx:115-125). For any extension without a
   row in the `extension_enabled` table, the settings payload from
   `/api/v1/extensions/settings` (superset-frontend/src/extensions/ExtensionsList.tsx:64-73
   and superset/superset/extensions/settings.py:28-35) does not include that `extension_id`,
   so `settings.enabled[id]` is `undefined`, and the API response does not define `enabled`
   at all. Thus `checked` evaluates to `undefined`, and the toggle renders unchecked even
   though `get_list` is documented to "List all enabled extensions"
   (superset/superset/extensions/api.py:79-83), causing the UI to misrepresent the enabled
   status for every extension without an explicit flag.
   ```
   </details>
   
   [Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=42833878ead44f21a490563e8d46a1f6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=42833878ead44f21a490563e8d46a1f6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   
   *(Use Cmd/Ctrl + Click for best experience)*
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset-frontend/src/extensions/ExtensionsList.tsx
   **Line:** 115:128
   **Comment:**
   	*Api Mismatch: The switch fallback uses `enabled` from the extensions list payload, but `/api/v1/extensions/` does not provide an `enabled` field (it only returns extension metadata), so untouched rows resolve to `undefined` and render with an incorrect checked state. Use an explicit default (for example `true`) or source enabled state solely from settings with a deterministic fallback.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40433&comment_hash=5477cc6b3b80b41f1460840f57c5e5366703f04cde8c3a7dd89103b3d2e007a3&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40433&comment_hash=5477cc6b3b80b41f1460840f57c5e5366703f04cde8c3a7dd89103b3d2e007a3&reaction=dislike'>👎</a>



##########
superset-frontend/src/components/ChatbotMount/index.tsx:
##########
@@ -0,0 +1,76 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { useState, useEffect } from 'react';
+import { SupersetClient } from '@superset-ui/core';
+import { css, useTheme } from '@apache-superset/core/theme';
+import { ErrorBoundary } from 'src/components/ErrorBoundary';
+import { getActiveChatbot } from 'src/core/chatbot';
+import { subscribeToLocation } from 'src/core/views';
+import { CHATBOT_LOCATION } from 'src/views/contributions';
+
+const CHATBOT_EDGE_MARGIN = 24;
+
+const ChatbotMount = () => {
+  const theme = useTheme();
+  const [adminSelectedId, setAdminSelectedId] = useState<string | null>(null);
+  const [activeChatbot, setActiveChatbot] = useState(() =>
+    getActiveChatbot(null),
+  );
+
+  useEffect(() => {
+    SupersetClient.get({ endpoint: '/api/v1/extensions/settings' })
+      .then(({ json }) => {
+        const id = json.result?.active_chatbot_id ?? null;
+        setAdminSelectedId(id);
+        setActiveChatbot(getActiveChatbot(id));
+      })
+      .catch(() => {
+        // Settings fetch failure is non-fatal — fall back to first-to-register.
+      });

Review Comment:
   **Suggestion:** The mount reads admin settings only once on initial render, so changing the default chatbot in the admin page during the same session does not update the active chatbot bubble until a full reload. Add a reactive refresh path (e.g., subscribe to settings changes or re-fetch after settings updates) so the mounted chatbot stays in sync. [stale reference]
   
   <details>
   <summary><b>Severity Level:</b> Major ⚠️</summary>
   
   ```mdx
   - ❌ Chatbot bubble ignores updated admin default selection.
   - ⚠️ Admin must reload page to see new chatbot.
   ```
   </details>
   <details>
   <summary><b>Steps of Reproduction ✅ </b></summary>
   
   ```mdx
   1. Start the Superset frontend using `App` (superset-frontend/src/views/App.tsx:48-93),
   which always renders `<ChatbotMount />` inside `<ExtensionsStartup>`
   (superset-frontend/src/views/App.tsx:57-89).
   
   2. On initial render, `ChatbotMount`
   (superset-frontend/src/components/ChatbotMount/index.tsx:29-55) runs its first
   `useEffect`, which GETs `/api/v1/extensions/settings` and sets `adminSelectedId` and
   `activeChatbot` from `json.result?.active_chatbot_id` (lines 36-41); this effect has an
   empty dependency array so it never runs again.
   
   3. As an admin, navigate to `/extensions/list/`, which is wired to the `Extensions` route
   when `FeatureFlag.EnableExtensions` is on
   (superset-frontend/src/views/routes.tsx:170-175); this lazy-loads `ExtensionsList`
   (superset-frontend/src/extensions/ExtensionsList.tsx:50-53), where changing the "Default
   chatbot" select (lines 145-163) calls `saveSettings` and sends a PUT to
   `/api/v1/extensions/settings` updating `active_chatbot_id`
   (superset/superset/extensions/api.py:190-215,
   superset/superset/extensions/settings.py:37-45).
   
   4. After the PUT succeeds, observe the chatbot bubble rendered by `ChatbotMount` in the
   bottom-right: it still uses the original `adminSelectedId` from its initial GET, because
   `adminSelectedId` is never updated again and `subscribeToLocation(CHATBOT_LOCATION, ...)`
   (superset-frontend/src/components/ChatbotMount/index.tsx:48-54) only re-runs
   `getActiveChatbot(adminSelectedId)` on view-registration changes, not on settings changes.
   The new default chosen in the admin page is not applied until the SPA is fully reloaded.
   ```
   </details>
   
   [Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=c2721a604fde4c178d4ccef3c1962d32&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=c2721a604fde4c178d4ccef3c1962d32&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   
   *(Use Cmd/Ctrl + Click for best experience)*
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset-frontend/src/components/ChatbotMount/index.tsx
   **Line:** 36:45
   **Comment:**
   	*Stale Reference: The mount reads admin settings only once on initial render, so changing the default chatbot in the admin page during the same session does not update the active chatbot bubble until a full reload. Add a reactive refresh path (e.g., subscribe to settings changes or re-fetch after settings updates) so the mounted chatbot stays in sync.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40433&comment_hash=a7305f15a9ad4250b97b7afbc5ac7b84ddf9baf05437d613c2d9d03dd4a194e5&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40433&comment_hash=a7305f15a9ad4250b97b7afbc5ac7b84ddf9baf05437d613c2d9d03dd4a194e5&reaction=dislike'>👎</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(extensions): adds chatbot P1-P2 [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #40433:
URL: https://github.com/apache/superset/pull/40433#issuecomment-4544659686

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/40433?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `46.80851%` with `25 lines` in your changes missing coverage. Please review.
   :warning: Please [upload](https://docs.codecov.com/docs/codecov-uploader) report for BASE (`chat-prototype@793ffb3`). [Learn more](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#section-missing-base-commit) about missing BASE report.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/40433?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...uperset-frontend/src/extensions/ExtensionsList.tsx](https://app.codecov.io/gh/apache/superset/pull/40433?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Fextensions%2FExtensionsList.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4dGVuc2lvbnMvRXh0ZW5zaW9uc0xpc3QudHN4) | 41.93% | [18 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/40433?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...set-frontend/src/components/ChatbotMount/index.tsx](https://app.codecov.io/gh/apache/superset/pull/40433?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Fcomponents%2FChatbotMount%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hhdGJvdE1vdW50L2luZGV4LnRzeA==) | 45.45% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/40433?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [superset-frontend/src/core/chatbot/index.ts](https://app.codecov.io/gh/apache/superset/pull/40433?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Fcore%2Fchatbot%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvcmUvY2hhdGJvdC9pbmRleC50cw==) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/40433?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@                Coverage Diff                @@
   ##             chat-prototype   #40433   +/-   ##
   =================================================
     Coverage                  ?   67.71%           
   =================================================
     Files                     ?     1852           
     Lines                     ?    77104           
     Branches                  ?    24705           
   =================================================
     Hits                      ?    52210           
     Misses                    ?    24894           
     Partials                  ?        0           
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/40433/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [javascript](https://app.codecov.io/gh/apache/superset/pull/40433/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.27% <46.80%> (?)` | |
   | [python](https://app.codecov.io/gh/apache/superset/pull/40433/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (?)` | |
   | [unit](https://app.codecov.io/gh/apache/superset/pull/40433/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/40433?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(extensions): chatbot mount point, singleton resolver, and admin settings (SIP P1+P2) [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #40433:
URL: https://github.com/apache/superset/pull/40433#issuecomment-4543935565

   ### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | 6a07ad2369cf9d761ef64f6da5dce1caa653474f |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a158ace47052e000744ce0e |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-40433--superset-docs-preview.netlify.app](https://deploy-preview-40433--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTQwNDMzLS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.sZ1l0pjpstoKjPp1Ub1ZICMfRNDP7tVHxMxBKnGyxiM)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   |<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcpBCoAgEADAv-w5cQvN6Ac9Y9UND6WLSBTR3_M2h3lBajmlwQowgK-UQ-rmfEe-9M7UdEjUfGlKRiVTT5HlKM8We5tptAsFNg7txIjojAmMDN8P) |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-40433--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(extensions): chatbot mount point, singleton resolver, and admin settings (SIP P1+P2) [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40433:
URL: https://github.com/apache/superset/pull/40433#issuecomment-4543926383

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(extensions): adds chatbot P1-P2 [superset]

Posted by "EnxDev (via GitHub)" <gi...@apache.org>.
EnxDev commented on PR #40433:
URL: https://github.com/apache/superset/pull/40433#issuecomment-4558321308

   I'm going to close it since I created multiple tasks to improve granularity.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org