You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/08/06 20:30:30 UTC

[GitHub] [samza] prateekm commented on a change in pull request #1408: SAMZA-2574: improve flexibility of SystemFactory interface

prateekm commented on a change in pull request #1408:
URL: https://github.com/apache/samza/pull/1408#discussion_r466668567



##########
File path: samza-core/src/main/java/org/apache/samza/util/DiagnosticsUtil.java
##########
@@ -144,7 +145,8 @@ public MetadataFileContents(String version, String metricsSnapshot) {
       }
       SystemFactory systemFactory = ReflectionUtil.getObj(diagnosticsSystemFactoryName.get(), SystemFactory.class);
       SystemProducer systemProducer =
-          systemFactory.getProducer(diagnosticsSystemStream.getSystem(), config, new MetricsRegistryMap());
+          systemFactory.getProducer(diagnosticsSystemStream.getSystem(), config, new MetricsRegistryMap(),
+              MethodHandles.lookup().lookupClass().getSimpleName());

Review comment:
       Why not use Class.getSimpleName() here too?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org