[GitHub] [tvm] comaniac commented on pull request #7070: Add autoscheduler support to tvmc

[GitBox <gi...@apache.org>]

comaniac commented on pull request #7070:
URL: https://github.com/apache/tvm/pull/7070#issuecomment-742737514


   > Hi @comaniac , @leandron ,
   > Thanks for your comments, now the code is way more sound. I thought of summing up here some issues left:
   > 
   > * It's now hard to make autotuner vs autoscheduler options mutually exclusive. So if I specify `--tuner` with `--enable-autoscheduling`, the tuner I selected won't be considered. This is because we are using default values, so a tuner will be always defined.
   
   I'm ok with this for now.
   
   > * Extracting tasks. @comaniac , you flagged the function, but this is actually how we do for the autotuner. I guess this is because we want to unit-test the function
   
   No worries. It is no longer an issue based on the latest implementation. It is reasonable to have separate functions for two frameworks launched by the same CLI command.
   
   > * Testing: I removed the `test_autoscheduler.py` test. When I wrote it, I was inspired by the `test_autotuner.py`. Can we agree on a set of tests we want to execute? @comaniac , I agree we should not test the autotuner, but only the user interface. But I fear to test the user interface, we will need to test a bit the functionality as well. What do you guys think?
   
   You're right. It's always hard to keep the proper unit test scope of TVMC. We should have a thread to discuss all of them and make a agreement. cc @leandron 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org