You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Christiaan Hees (JIRA)" <ji...@apache.org> on 2009/10/14 10:20:31 UTC
[jira] Created: (SHINDIG-1190) userprefs don't get saved
userprefs don't get saved
-------------------------
Key: SHINDIG-1190
URL: https://issues.apache.org/jira/browse/SHINDIG-1190
Project: Shindig
Issue Type: Bug
Components: Javascript
Reporter: Christiaan Hees
Priority: Trivial
At shindig/javascript/container/gadgets.js:639 in the handleSaveUserPrefs it makes this check:
if (input.type != 'hidden')
I think this should actually be:
if (input.type == 'hidden')
cause at the moment it actually skips all the relevant fields which results in prefs being empty and thus not getting saved.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-1190) userprefs don't get saved
Posted by "Benjamin McCann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771190#action_12771190 ]
Benjamin McCann commented on SHINDIG-1190:
------------------------------------------
I found out why the if block was causing trouble for the original bug reporter. It's because the prefs dialog updates hidden inputs when you check/uncheck a boolean preference. Text fields are non-hidden, so reversing the if statement isn't the right fix. We should instead remove the if statement.
> userprefs don't get saved
> -------------------------
>
> Key: SHINDIG-1190
> URL: https://issues.apache.org/jira/browse/SHINDIG-1190
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Reporter: Christiaan Hees
> Assignee: Paul Lindner
> Priority: Trivial
> Fix For: 1.1-BETA4
>
> Attachments: test.html
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> At shindig/javascript/container/gadgets.js:639 in the handleSaveUserPrefs it makes this check:
> if (input.type != 'hidden')
> I think this should actually be:
> if (input.type == 'hidden')
> cause at the moment it actually skips all the relevant fields which results in prefs being empty and thus not getting saved.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-1190) userprefs don't get saved
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-1190.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.1-BETA5
okay, resolved this by removing the if statement.
> userprefs don't get saved
> -------------------------
>
> Key: SHINDIG-1190
> URL: https://issues.apache.org/jira/browse/SHINDIG-1190
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Reporter: Christiaan Hees
> Assignee: Paul Lindner
> Priority: Trivial
> Fix For: 1.1-BETA5
>
> Attachments: test.html
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> At shindig/javascript/container/gadgets.js:639 in the handleSaveUserPrefs it makes this check:
> if (input.type != 'hidden')
> I think this should actually be:
> if (input.type == 'hidden')
> cause at the moment it actually skips all the relevant fields which results in prefs being empty and thus not getting saved.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-1190) userprefs don't get saved
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-1190.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.1-BETA4
Validated with
http://widgets.nytimes.com/packages/html/igoogle/topstories.xml
Thanks!
> userprefs don't get saved
> -------------------------
>
> Key: SHINDIG-1190
> URL: https://issues.apache.org/jira/browse/SHINDIG-1190
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Reporter: Christiaan Hees
> Priority: Trivial
> Fix For: 1.1-BETA4
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> At shindig/javascript/container/gadgets.js:639 in the handleSaveUserPrefs it makes this check:
> if (input.type != 'hidden')
> I think this should actually be:
> if (input.type == 'hidden')
> cause at the moment it actually skips all the relevant fields which results in prefs being empty and thus not getting saved.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SHINDIG-1190) userprefs don't get saved
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner reopened SHINDIG-1190:
-----------------------------------
Assignee: Paul Lindner
will take a closer look at this. Thanks.
> userprefs don't get saved
> -------------------------
>
> Key: SHINDIG-1190
> URL: https://issues.apache.org/jira/browse/SHINDIG-1190
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Reporter: Christiaan Hees
> Assignee: Paul Lindner
> Priority: Trivial
> Fix For: 1.1-BETA4
>
> Attachments: test.html
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> At shindig/javascript/container/gadgets.js:639 in the handleSaveUserPrefs it makes this check:
> if (input.type != 'hidden')
> I think this should actually be:
> if (input.type == 'hidden')
> cause at the moment it actually skips all the relevant fields which results in prefs being empty and thus not getting saved.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-1190) userprefs don't get saved
Posted by "Benjamin McCann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin McCann updated SHINDIG-1190:
-------------------------------------
Attachment: test.html
This change needs to be reverted. The inputs generated by the prefs dialog script are not hidden as demonstrated by the attached file. You do not want to skip all non-hidden fields.
> userprefs don't get saved
> -------------------------
>
> Key: SHINDIG-1190
> URL: https://issues.apache.org/jira/browse/SHINDIG-1190
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Reporter: Christiaan Hees
> Priority: Trivial
> Fix For: 1.1-BETA4
>
> Attachments: test.html
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> At shindig/javascript/container/gadgets.js:639 in the handleSaveUserPrefs it makes this check:
> if (input.type != 'hidden')
> I think this should actually be:
> if (input.type == 'hidden')
> cause at the moment it actually skips all the relevant fields which results in prefs being empty and thus not getting saved.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.