[GitHub] [fineract] BLasan commented on a change in pull request #1933: Feat: Filter transactions from last interest posting date

[GitBox <gi...@apache.org>]

BLasan commented on a change in pull request #1933:
URL: https://github.com/apache/fineract/pull/1933#discussion_r739048567



##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountAssembler.java
##########
@@ -313,6 +323,44 @@ public SavingsAccount assembleFrom(final Long savingsId) {
         return account;
     }
 
+    public SavingsAccount assembleSavingsFrom(final Long savingsId) {
+        final SavingsAccount account = this.savingsAccountRepository.findOneWithNotFoundDetection(savingsId);

Review comment:
       You mean annotate with @Transactional(readOnly=true) on `findOneWithNotFoundDetection` function? But we'll be modifying the account (set filtered account transactions to the Transient variable) in this function




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org