You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/04 23:57:14 UTC
[GitHub] [tvm] trevor-m opened a new pull request #7977: [BYOC] Remove ext params stored in metadata from params to avoid duplication
trevor-m opened a new pull request #7977:
URL: https://github.com/apache/tvm/pull/7977
This PR is similar to #7564 but implemented differently.
During compilation, weights from external modules are stored in the MetadataModule (.so), but they are still kept in params so they end up being duplicated.
This PR will remove from params only the weights which were stored in MetadataModule, solving the weight duplication issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on pull request #7977: [BYOC] Remove ext params stored in metadata from params to avoid duplication
Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #7977:
URL: https://github.com/apache/tvm/pull/7977#issuecomment-833697489
Thanks @trevor-m
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac merged pull request #7977: [BYOC] Remove ext params stored in metadata from params to avoid duplication
Posted by GitBox <gi...@apache.org>.
comaniac merged pull request #7977:
URL: https://github.com/apache/tvm/pull/7977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] trevor-m commented on pull request #7977: [BYOC] Remove ext params stored in metadata from params to avoid duplication
Posted by GitBox <gi...@apache.org>.
trevor-m commented on pull request #7977:
URL: https://github.com/apache/tvm/pull/7977#issuecomment-832334872
Thanks @comaniac
I added an assert to an existing test.
Without this pr, the assert fails:
```
# Params will be stored in metadata module.
> assert len(graph_module.get_params()) == 0
E AssertionError: assert 1 == 0
E + where 1 = len({'ccompiler_0_const_0': <tvm.nd.NDArray shape=(1,), cpu(0)>\narray([1.], dtype=float32)})
E + where {'ccompiler_0_const_0': <tvm.nd.NDArray shape=(1,), cpu(0)>\narray([1.], dtype=float32)} = <bound method GraphExecutorFactoryModule.get_params of <tvm.relay.backend.graph_executor_factory.GraphExecutorFactoryModule object at 0x7fd7e2831dd8>>()
E + where <bound method GraphExecutorFactoryModule.get_params of <tvm.relay.backend.graph_executor_factory.GraphExecutorFactoryModule object at 0x7fd7e2831dd8>> = <tvm.relay.backend.graph_executor_factory.GraphExecutorFactoryModule object at 0x7fd7e2831dd8>.get_params
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] trevor-m commented on pull request #7977: [BYOC] Remove ext params stored in metadata from params to avoid duplication
Posted by GitBox <gi...@apache.org>.
trevor-m commented on pull request #7977:
URL: https://github.com/apache/tvm/pull/7977#issuecomment-832329467
@comaniac @zhiics @mbaret @d-smirnov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org