[GitHub] sijie opened a new pull request #1319: Issue 1316: A bookie with non-writable dirs should be able to start in readonly mode

[GitBox <gi...@apache.org>]

sijie opened a new pull request #1319:  Issue 1316: A bookie with non-writable dirs should be able to start in readonly mode
URL: https://github.com/apache/bookkeeper/pull/1319
 
 
   Descriptions of the changes in this PR:
   
   *Problem*
   
   Bookie failed to start when it doesn't have non-writable dirs. Issue is reported at #1316 
   
   *Solution*
   
   - Introduce a setting `minUsageSizeForEntryLogCreation` to allow creating entry logs even when there is no writable dirs. This setting is replacing `getIsForceGCAllowWhenNoSpace` for creating new log, since entry log files are created not only for gc/compaction. It can also happen on startup and also journal replays.
   
   - Defer creating entry log files until first write happens, when there is no writable ledger dirs.
   
   - add bunch of tests for EntryLog and Bookie initialization.
   
   Master Issue: #1316 
   
   > ---
   > Be sure to do all of the following to help us incorporate your contribution
   > quickly and easily:
   >
   > If this PR is a BookKeeper Proposal (BP):
   >
   > - [ ] Make sure the PR title is formatted like:
   >     `<BP-#>: Description of bookkeeper proposal`
   >     `e.g. BP-1: 64 bits ledger is support`
   > - [ ] Attach the master issue link in the description of this PR.
   > - [ ] Attach the google doc link if the BP is written in Google Doc.
   >
   > Otherwise:
   > 
   > - [ ] Make sure the PR title is formatted like:
   >     `<Issue #>: Description of pull request`
   >     `e.g. Issue 123: Description ...`
   > - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`.
   > - [ ] Replace `<Issue #>` in the title with the actual Issue number.
   > 
   > ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services