You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/12/30 22:27:11 UTC

[GitHub] [pulsar] zuquan-song opened a new pull request #5968: Vagrantfile update for build dependency

zuquan-song opened a new pull request #5968: Vagrantfile update for build dependency
URL: https://github.com/apache/pulsar/pull/5968
 
 
   <!--
   ### Contribution Checklist
     
     - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
       Skip *Issue XYZ* if there is no associated github issue for this pull request.
       Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   *(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
   
   Fixes #5967
   
   ### Motivation
   Cannot build the project successfully.
   
   ### Modifications
   Add install commands to install the unzip zip tools when vm sets up
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (don't know)
     - The default values of configurations: ( no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: ( no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] zuquan-song commented on issue #5968: Vagrantfile update for build dependency

Posted by GitBox <gi...@apache.org>.
zuquan-song commented on issue #5968: Vagrantfile update for build dependency
URL: https://github.com/apache/pulsar/pull/5968#issuecomment-569816513
 
 
   It's weird that my update affects the Jenkins Unit Tests because I just modify the Vagrantfile. Anyone could help? Thanks! 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] tuteng commented on issue #5968: Vagrantfile update for build dependency

Posted by GitBox <gi...@apache.org>.
tuteng commented on issue #5968: Vagrantfile update for build dependency
URL: https://github.com/apache/pulsar/pull/5968#issuecomment-569845633
 
 
   run cpp tests
   run java8 tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie merged pull request #5968: Vagrantfile update for build dependency

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #5968: Vagrantfile update for build dependency
URL: https://github.com/apache/pulsar/pull/5968
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] zuquan-song commented on issue #5968: Vagrantfile update for build dependency

Posted by GitBox <gi...@apache.org>.
zuquan-song commented on issue #5968: Vagrantfile update for build dependency
URL: https://github.com/apache/pulsar/pull/5968#issuecomment-569860012
 
 
   run cpp tests
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] tuteng commented on issue #5968: Vagrantfile update for build dependency

Posted by GitBox <gi...@apache.org>.
tuteng commented on issue #5968: Vagrantfile update for build dependency
URL: https://github.com/apache/pulsar/pull/5968#issuecomment-569832291
 
 
   run cpp tests
   run java8 tests
   run integration tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] zuquan-song commented on issue #5968: Vagrantfile update for build dependency

Posted by GitBox <gi...@apache.org>.
zuquan-song commented on issue #5968: Vagrantfile update for build dependency
URL: https://github.com/apache/pulsar/pull/5968#issuecomment-569818297
 
 
   run java8 tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services