[GitHub] [james-project] chibenwa commented on pull request #280: JAMES-3477 demonstrates concurrency issue in MimeMessageCOW

[GitBox <gi...@apache.org>]

chibenwa commented on pull request #280:
URL: https://github.com/apache/james-project/pull/280#issuecomment-744292453


   > I know all the effort that has been invested in all this, but I would very much like to see the benchmark that led to implement this copy on write scheme instead of simply copying on every instantiation. 
   
   :+1: we need to know if it worth it
   
   We need to see if this code complexity is worth it (I am not super fan of the proposed solution here that partially resolves the problem)
   
   > It feels like trying to preserver heap space at the cost of synchronization this is optimization territory and should be backed by measurements that are kept up to date for new releases.
   
   We are trying to avoid disk writes that could happen from this copy from what I understand.
   
   > I wonder what the perf profile of the server would look like with a more naive copy approach.
   
   We need to design a test, where emails are actually split (matcher splitting leads to several copies being hold)
   
   We could do micro benchmark of 1000 processed emails of 100KB split 5 time against both implems. What would you think ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org