[jira] Closed: (WICKET-1017) POSITIVE and NEGATIVE in NumberValidator are badly named (or contain a bug)

["Johan Compagner (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johan Compagner closed WICKET-1017.
-----------------------------------

    Resolution: Fixed

this works to

/**
	 * a validator for ensuring for a positive number value
	 */
	public static final NumberValidator POSITIVE = minimum(Double.MIN_VALUE);

	/**
	 * a validator for ensuring a negative number value
	 */
	public static final NumberValidator NEGATIVE = maximum(-Double.MIN_VALUE);

But maybe seb can shoot a hole in this. But my added unit test say it works!

I added numerous unit test on the way for the NumberValidator classes. So we have even a better coverage!

> POSITIVE and NEGATIVE in NumberValidator are badly named (or contain a bug)
> ---------------------------------------------------------------------------
>
>                 Key: WICKET-1017
>                 URL: https://issues.apache.org/jira/browse/WICKET-1017
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta3
>            Reporter: Sebastiaan van Erk
>            Assignee: Johan Compagner
>            Priority: Minor
>             Fix For: 1.3.0-rc3
>
>
> The POSITIVE validator is a new number validator with minimum 0.
> However 0 is not positive. Therefore, the validator should be called NONNEGATIVE. That or it should not allow 0.
> The validation messages (at least in Dutch) state that the number must be LARGER than 0 if I enter a negative number.
> However, 0 is of course accepted.
> Thus, for consistency I think it would probably be best to fix this one way or the other.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.