[GitHub] [incubator-pagespeed-mod] JialuZhang commented on issue #676: Summary of mod_rewrite and mod_pagespeed interactions

[GitBox <gi...@apache.org>]

JialuZhang commented on issue #676:
URL: https://github.com/apache/incubator-pagespeed-mod/issues/676#issuecomment-785271610


   @GoogleCodeExporter 
   
   Thanks for the work around. However, in your posted configuration, the line: "RewriteEngine Off" is a misconfiguration, and adding it to your system will not change any system behavior.
   Why "RewriteEngine Off" is allowed by Apache is that, if you include multiple "RewriteRule" parameters in your configuration, then instead of commenting them all, you can explicitly using “RewriteEngine Off” to disable all "RewriteRule".
   
   More importantly, the default value of “RewriteEngine" is already an "off", so adding “RewriteEngine Off" is quite unnecessary and it may cause confusion to users.
   
   Since herein there is no "RewriteRule", deleting “RewriteEngine Off” would be ideal.
   
   Related Apache source code snippet:
   ```
   run_rewritemap_programs(server_rec *s , apr_pool_t *p){
   if (conf->state == ENGINE_DISABLED) { // usage of "RewriteEngine"
     return APR_SUCCESS; // early return
   rewritemap_program(...); // usage of "RewriteRule" 
   }
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org