You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by "chenBright (via GitHub)" <gi...@apache.org> on 2025/04/22 08:16:05 UTC
[PR] Fix compile errors of json2pb (brpc)
chenBright opened a new pull request, #2956:
URL: https://github.com/apache/brpc/pull/2956
### What problem does this PR solve?
Issue Number: resolve #2954
Problem Summary:
### What is changed and the side effects?
Changed:
Side effects:
- Performance effects(性能影响):
- Breaking backward compatibility(向后兼容性):
---
### Check List:
- Please make sure your changes are compilable(请确保你的更改可以通过编译).
- When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
- Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).(请遵循贡献者准则).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] Fix compile errors of json2pb (brpc)
Posted by "zhangqiongyu (via GitHub)" <gi...@apache.org>.
zhangqiongyu commented on PR #2956:
URL: https://github.com/apache/brpc/pull/2956#issuecomment-2823142808
同样问题，感谢老哥修复
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] Fix compile errors of json2pb (brpc)
Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm commented on code in PR #2956:
URL: https://github.com/apache/brpc/pull/2956#discussion_r2053625043
##########
.github/workflows/ci-linux.yml:
##########
@@ -92,29 +137,74 @@ jobs:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v2
- - uses: ./.github/actions/install-essential-dependences
+ - uses: ./.github/actions/install-essential-dependencies
- uses: ./.github/actions/init-make-config
with:
options: --cc=clang --cxx=clang++ --werror
- name: compile
run: |
- make -j ${{env.proc_num}}
+ make -j ${{env.proc_num}}
+
+ clang-compile-with-make-protobuf-3-5-1:
Review Comment:
There are too many combinations. I seems that Apache had informed that no more than 20 jobs in one CI process. Maybe we can simplify these combinations. When we change one parameter (such as protobuf version), we keep the other parameters fixed (such as compiler type, build tool, OS version).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] Fix compile errors of json2pb (brpc)
Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm merged PR #2956:
URL: https://github.com/apache/brpc/pull/2956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] Fix compile errors of json2pb (brpc)
Posted by "chenBright (via GitHub)" <gi...@apache.org>.
chenBright commented on code in PR #2956:
URL: https://github.com/apache/brpc/pull/2956#discussion_r2055594758
##########
.github/workflows/ci-linux.yml:
##########
@@ -92,29 +137,74 @@ jobs:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v2
- - uses: ./.github/actions/install-essential-dependences
+ - uses: ./.github/actions/install-essential-dependencies
- uses: ./.github/actions/init-make-config
with:
options: --cc=clang --cxx=clang++ --werror
- name: compile
run: |
- make -j ${{env.proc_num}}
+ make -j ${{env.proc_num}}
+
+ clang-compile-with-make-protobuf-3-5-1:
Review Comment:
I have merged some jobs and now there are only 15 jobs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org