You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/13 03:08:47 UTC

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #774: mm: mm_heap: Fix deadlock in mm_trysemaphore in SMP mode

masayuki2009 opened a new pull request #774: mm: mm_heap: Fix deadlock in mm_trysemaphore in SMP mode
URL: https://github.com/apache/incubator-nuttx/pull/774
 
 
   ### Summary
   
   - During checking the latest master code, I noticed that smp test application caused deadlock.
   - Finally I found the root cause of this issue which was introduced in https://github.com/apache/incubator-nuttx/pull/761
   - Actually the above PR did not call leave_critical_section() when exiting the function.
   - This PR sets the return value and jumps to the errout so that leave_critical_section() can be called in SMP mode.
   
   ### Impact
   
   - This PR affects mm_trysemaphore() in SMP mode only.
   
   ### Testing
   
   - Run smp and ostest applications for maix-bit:smp and esp32-core:smp on qemu.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #774: mm: mm_heap: Fix deadlock in mm_trysemaphore in SMP mode

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #774: mm: mm_heap: Fix deadlock in mm_trysemaphore in SMP mode
URL: https://github.com/apache/incubator-nuttx/pull/774#issuecomment-612735274
 
 
   @masayuki2009 Thanks for the fix, @liguiding please take a look.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #774: mm: mm_heap: Fix deadlock in mm_trysemaphore in SMP mode

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #774: mm: mm_heap: Fix deadlock in mm_trysemaphore in SMP mode
URL: https://github.com/apache/incubator-nuttx/pull/774
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services