[jira] [Commented] (ARTEMIS-4183) Broker diagram is not properly updated when new nodes become available

["Erwin Dondorp (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693705#comment-17693705 ] 

Erwin Dondorp commented on ARTEMIS-4183:
----------------------------------------

ANALYSIS:

the GUI figures out what to display in function {{load()}}
just after the initial call to {{load()}}, an assignment to variable {{ctrl.hiddenRelations}} is done.
but when the same function is called from the Refresh-button, such assignment is not done, thus keeping the old value.

The variable {{ctrl.hiddenRelations}} was introduced on 6-jun-2021 for ARTEMIS-3043

SOLUTIONS:

solution 1a:
add the assignment also after the {{load()}} call for the Refresh-button
solution 1b:
move the assignment to the {{load()}} function
solution 2:
do not maintain variable {{ctrl.hiddenRelations}} and only use variable {{ctrl.relations}}

SOLUTION:

As the use of variable {{ctrl.hiddenRelations}} is unclear to me, solution #2 has been implemented in the PR.

@andytaylor: can you comment on this solution?

> Broker diagram is not properly updated when new nodes become available
> ----------------------------------------------------------------------
>
>                 Key: ARTEMIS-4183
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4183
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: 2.28.0
>            Reporter: Erwin Dondorp
>            Priority: Minor
>         Attachments: image-2023-02-26-16-36-25-761.png
>
>
> Using an auto discovery cluster.
> When the number of nodes is reduced, the broker diagram is properly updated when the Refresh button is used.
> When the number of nodes is enlarged, the broker diagram is _not_ properly updated when the Refresh button is used. The new nodes are visible, but their cluster-connections are not shown. The diagram can easily be fixed by using the browser refresh button instead, or by temporarily switching tabs within the Artemis console.
> The following diagram shows the effect:
> !image-2023-02-26-16-36-25-761.png! 
> left image: initial situation with 5 nodes
> middle image: 3 nodes are added, and after Refresh button is used
> right image: after page refresh
> I know the JS code from the Console fairly well. I suspect a synchronisation error between the variables {{relations}} and {{hiddenRelations}}. I'll investigate and try to add a PR.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)