[GitHub] [tomcat] michael-o edited a comment on pull request #463: Add support for additional user attributes to TomcatPrincipal

[GitBox <gi...@apache.org>]

michael-o edited a comment on pull request #463:
URL: https://github.com/apache/tomcat/pull/463#issuecomment-1031428724


   > What about the example JSP application? Shouldn't we add support for dumping user attributes with this commit? See [#463 (comment)](https://github.com/apache/tomcat/pull/463#issuecomment-1015511489) (2nd paragraph)
   
   Personally, I wouldn't do this. This will limit the semantics of your PR, taking away to work with interface only. My [custom principal](https://michael-o.github.io/tomcatspnegoad/apidocs/net/sf/michaelo/tomcat/realm/ActiveDirectoryPrincipal.html) uses this one as well so Tomcat can internally use the provided methods otherwise it feels foreign to Tomcat.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org