You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "eolivelli (via GitHub)" <gi...@apache.org> on 2023/02/28 08:06:47 UTC
[GitHub] [pulsar] eolivelli opened a new pull request, #19661: [bugfix] Fix race condition that leads to caching failed CompletableFutures in ConnectionPool
eolivelli opened a new pull request, #19661:
URL: https://github.com/apache/pulsar/pull/19661
### Motivation
There is a race condition while creating a Connection and putting it into the cache.
The operation may fail before that the CompletableFuture is put into the pool map and so cleanupConnection fails to remove the new connection from the map (because it is not there yet)
This is very likely to happen on k8s while a broker is not "ready"
The problem is that UnknownHostException fails very quickly (probably on the same thread), and the "exceptionally" block is executed before we put the CompletableFuture into the `pool` map, and so the "remove" operation fails
### Modifications
Eagerly remove the CompletableFuture from the cache if it is "failed".
There is no need to retry, the client eventually will retry, and also retrying immediately will probably fail.
### Verifying this change
I am not adding tests, this race condition is hard to reproduce. But it happens sometimes on some k8s clusters during fault injection tests.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #19661: [fix][client] Fix race condition that leads to caching failed CompletableFutures in ConnectionPool
Posted by "eolivelli (via GitHub)" <gi...@apache.org>.
eolivelli merged PR #19661:
URL: https://github.com/apache/pulsar/pull/19661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #19661: [fix][client] Fix race condition that leads to caching failed CompletableFutures in ConnectionPool
Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on PR #19661:
URL: https://github.com/apache/pulsar/pull/19661#issuecomment-1610271910
As discussed on the mailing list https://lists.apache.org/thread/w4jzk27qhtosgsz7l9bmhf1t7o9mxjhp, there is no plan to release 2.9.6, so I am going to remove the release/2.9.6 label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #19661: [fix][client] Fix race condition that leads to caching failed CompletableFutures in ConnectionPool
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #19661:
URL: https://github.com/apache/pulsar/pull/19661#issuecomment-1447797364
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on pull request #19661: [fix][client] Fix race condition that leads to caching failed CompletableFutures in ConnectionPool
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- commented on PR #19661:
URL: https://github.com/apache/pulsar/pull/19661#issuecomment-1447919042
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org