You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by sp...@apache.org on 2016/09/29 19:55:36 UTC

[2/2] tinkerpop git commit: Merge remote-tracking branch 'origin/TINKERPOP-790'

Merge remote-tracking branch 'origin/TINKERPOP-790'

Conflicts:
	docs/src/upgrade/release-3.2.x-incubating.asciidoc


Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/4fc05e8c
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/4fc05e8c
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/4fc05e8c

Branch: refs/heads/master
Commit: 4fc05e8cbd484997a2613282870b68cf712d04e8
Parents: 3d17824 b732718
Author: Stephen Mallette <sp...@genoprime.com>
Authored: Thu Sep 29 15:55:24 2016 -0400
Committer: Stephen Mallette <sp...@genoprime.com>
Committed: Thu Sep 29 15:55:24 2016 -0400

----------------------------------------------------------------------
 CHANGELOG.asciidoc                              |  1 +
 .../src/reference/gremlin-applications.asciidoc | 10 +++-
 .../upgrade/release-3.2.x-incubating.asciidoc   | 25 +++++++++
 .../traversal/RemoteTraversalSideEffects.java   |  6 ++-
 .../gremlin/process/traversal/Traversal.java    |  7 ++-
 .../process/traversal/TraversalSource.java      | 15 +++---
 .../dsl/graph/GraphTraversalSource.java         | 24 +++++++--
 .../dsl/graph/GraphTraversalSourceTest.java     | 53 ++++++++++++++++++++
 .../driver/remote/DriverRemoteTraversal.java    | 13 +++++
 .../DriverRemoteTraversalSideEffects.java       |  7 +++
 10 files changed, 147 insertions(+), 14 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/4fc05e8c/CHANGELOG.asciidoc
----------------------------------------------------------------------

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/4fc05e8c/docs/src/upgrade/release-3.2.x-incubating.asciidoc
----------------------------------------------------------------------
diff --cc docs/src/upgrade/release-3.2.x-incubating.asciidoc
index cc1cf2e,0615099..0ba09bd
--- a/docs/src/upgrade/release-3.2.x-incubating.asciidoc
+++ b/docs/src/upgrade/release-3.2.x-incubating.asciidoc
@@@ -118,15 -118,31 +118,40 @@@ gremlin> g.V().hasLabel("software").cou
  TinkerPop 3.2.3 fixes this misbehavior and all `has()` method overloads behave like before, except that they no longer
  support no arguments.
  
 +Deprecated reconnectInitialDelay
 +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 +
 +The `reconnectInitialDelay` setting on the `Cluster` builder has been deprecated. It no longer serves any purpose.
 +The value for the "initial delay" now comes from `reconnectInterval` (there are no longer two separate settings to
 +control).
 +
 +See: link:https://issues.apache.org/jira/browse/TINKERPOP-1460[TINKERPOP-1460]
 +
+ TraversalSource.close()
+ ^^^^^^^^^^^^^^^^^^^^^^^
+ 
+ `TraversalSource` now implements `AutoCloseable`, which means that the `close()` method is now available. This new
+ method is important in cases where `withRemote()` is used, as `withRemote()` can open "expensive" resources that need
+ to be released.
+ 
+ In the case of TinkerPop's `DriverRemoteConnection`, `close()` will destroy the `Client` instance that is created
+ internally by `withRemote()` as shown below:
+ 
+ [source,text]
+ ----
+ gremlin> graph = EmptyGraph.instance()
+ ==>emptygraph[empty]
+ gremlin> g = graph.traversal().withRemote('conf/remote-graph.properties')
+ ==>graphtraversalsource[emptygraph[empty], standard]
+ gremlin> g.close()
+ gremlin>
+ ----
+ 
+ Note that the `withRemote()` method will call `close()` on a `RemoteConnection` passed directly to it as well, so
+ there is no need to do that manually.
+ 
+ See: link:https://issues.apache.org/jira/browse/TINKERPOP-790[TINKERPOP-790]
+ 
  Upgrading for Providers
  ~~~~~~~~~~~~~~~~~~~~~~~