You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cordova.apache.org by Simon MacDonald <si...@gmail.com> on 2013/05/14 03:21:51 UTC

Please look at this pull request

I don't have a PC right now to check this out but a lot of people on
WIndows have complained about this on the list and apparently this fixes
the issue:

https://github.com/apache/cordova-android/pull/54

Thanks...

Simon Mac Donald
http://hi.im/simonmacdonald

Re: Please look at this pull request

Posted by Andrew Grieve <ag...@chromium.org>.

Thanks for testing it out Benn! I committed it and created an issue.
https://issues.apache.org/jira/browse/CB-3392


On Tue, May 14, 2013 at 5:33 PM, Benn Mapes <be...@gmail.com> wrote:

> Took a look at the request and found a few new errors with the windows
> create script since things have changed a bit. I just added quotes around
> the variables to keep it consistent with the other commands.
>
> I added a commit as well to fix the other changes. If someone with commit
> access to the repo could merge/rebase this in that would be great.
>
> Here is my pull request :
> https://github.com/apache/cordova-android/pull/55
>
>
> On Mon, May 13, 2013 at 6:21 PM, Simon MacDonald
> <si...@gmail.com>wrote:
>
> > I don't have a PC right now to check this out but a lot of people on
> > WIndows have complained about this on the list and apparently this fixes
> > the issue:
> >
> > https://github.com/apache/cordova-android/pull/54
> >
> > Thanks...
> >
> > Simon Mac Donald
> > http://hi.im/simonmacdonald
> >
>

Re: Please look at this pull request

Posted by Benn Mapes <be...@gmail.com>.

Took a look at the request and found a few new errors with the windows
create script since things have changed a bit. I just added quotes around
the variables to keep it consistent with the other commands.

I added a commit as well to fix the other changes. If someone with commit
access to the repo could merge/rebase this in that would be great.

Here is my pull request : https://github.com/apache/cordova-android/pull/55

On Mon, May 13, 2013 at 6:21 PM, Simon MacDonald
<si...@gmail.com>wrote:

> I don't have a PC right now to check this out but a lot of people on
> WIndows have complained about this on the list and apparently this fixes
> the issue:
>
> https://github.com/apache/cordova-android/pull/54
>
> Thanks...
>
> Simon Mac Donald
> http://hi.im/simonmacdonald
>